src/ic/handler-compiler.cc - Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/handler-compiler.cc

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Patch Set: fixing merge conflicts Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/handler-compiler.cc

diff --git a/src/ic/handler-compiler.cc b/src/ic/handler-compiler.cc

index 006f3ef3913dd51d6ae4f9bd26e1c8b35e78a1be..f3f3561ed9f6c2310d769aebbc856118fc97c59a 100644

--- a/src/ic/handler-compiler.cc

+++ b/src/ic/handler-compiler.cc

@@ -161,7 +161,7 @@ void PropertyHandlerCompiler::NonexistentFrontendHeader(Handle<Name> name,

last_map = map();

// If |type| has null as its prototype, |holder()| is

// Handle<JSObject>::null().

- DCHECK(last_map->prototype() == isolate()->heap()->null_value());

+ DCHECK(last_map->prototype()->IsNull(isolate()));

} else {

last_map = handle(holder()->map());

// This condition matches the branches below.

« no previous file with comments | « src/full-codegen/x87/full-codegen-x87.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »