src/runtime/runtime-array.cc - Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 2601503002: Add Object::IsNullOrUndefined(Isolate*) helper method (Closed)

Patch Set: fixing merge conflicts Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 92bf848829203e5fa2be246e2709a68634428899..ad374d22b29b874adfb6b4c4c852cedce14739ff 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -538,7 +538,7 @@ RUNTIME_FUNCTION(Runtime_ArrayIndexOf) {

// Let O be ? ToObject(this value).

Handle<Object> receiver_obj = args.at(0);

- if (receiver_obj->IsNull(isolate) || receiver_obj->IsUndefined(isolate)) {

+ if (receiver_obj->IsNullOrUndefined(isolate)) {

THROW_NEW_ERROR_RETURN_FAILURE(

isolate, NewTypeError(MessageTemplate::kCalledOnNullOrUndefined,

isolate->factory()->NewStringFromAsciiChecked(

« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »