arc: Use GET_INTERFACE_FOR_METHOD macro

arc: Use GET_INTERFACE_FOR_METHOD macro

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Committed: https://crrev.com/0843b0c2e8dcb65871f1c2be55dcd1198124666a
Cr-Commit-Position: refs/heads/master@{#441464}

[Luis Héctor Chávez, 2016-12-22 21:58:40]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:58:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Luis Héctor Chávez, 2016-12-22 22:02:48]

lhchavez@chromium.org changed reviewers:
+ afakhry@chromium.org, dmazzoni@chromium.org, georgesak@chromium.org,
xiyuan@chromium.org, yusukes@chromium.org

[Luis Héctor Chávez, 2016-12-22 22:02:49]

PTAL

yusukes@: */arc/*
afakhry@: chrome/browser/task_manager
georgesak@: chrome/browser/memory
dmazzoni@: chrome/browser/speech
xiyuan@: chrome/browser

[Luis Héctor Chávez, 2016-12-22 22:04:05]

lhchavez@chromium.org changed reviewers:
+ yzshen@chromium.org

[Luis Héctor Chávez, 2016-12-22 22:04:06]

+yzshen@ FYI

[commit-bot: I haz the power, 2016-12-22 22:46:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 22:46:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-12-22 23:12:22]

c/b lgtm

[dmazzoni, 2016-12-28 17:26:19]

chrome/browser/speech lgtm

[afakhry, 2017-01-03 17:17:52]

c/b/task_manager lgtm

[Luis Héctor Chávez, 2017-01-03 18:12:13]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:12:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:43:23]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Luis Héctor Chávez, 2017-01-03 19:09:50]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 19:10:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Georges Khalil, 2017-01-03 19:29:36]

chrome/browser/memory lgtm

[commit-bot: I haz the power, 2017-01-03 19:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 19:40:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2017-01-04 19:04:09]

lhchavez@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Luis Héctor Chávez, 2017-01-04 19:04:09]

+maxbogue@ for chrome/browser/sync/test/

[Luis Héctor Chávez, 2017-01-04 19:04:12]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2017-01-04 19:06:02]

chrome/browser/sync/test/ lgtm

[commit-bot: I haz the power, 2017-01-04 19:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 19:31:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Luis Héctor Chávez, 2017-01-04 19:33:08]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:33:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-04 19:59:13]

nice! Thanks for doing this.

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc
(right):

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc:32:
mojom::FileSystemInstance* GetFileSystemInstance(
Can you define ARC_GET_MIN_VERSION_FOR_METHOD macro in
components/arc/instance_holder.h and remove constants at L25-28?

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_arc_package_helper.cc (right):

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_arc_package_helper.cc:187:
static_cast<FakeAppInstance*>(GET_INSTANCE_FOR_METHOD(
(not related to your CL, so no reply needed but.. why static_cast needed
here???)

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:40: // Minimum required
versions.
Same. Can you remove these?

https://codereview.chromium.org/2599673005/diff/80001/components/arc/instance...
File components/arc/instance_holder.h (right):

https://codereview.chromium.org/2599673005/diff/80001/components/arc/instance...
components/arc/instance_holder.h:21: #define GET_INSTANCE_FOR_METHOD(holder,
method_name)            \
nit: I'm a bit concerned about defining a macro without a prefix (e.g. component
name) in a header file. What about adding 'ARC' to the name? Maybe
ARC_GET_INSTANCE_FOR_METHOD or GET_ARC_INSTANCE_FOR_METHOD. WDYT?

https://codereview.chromium.org/2599673005/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_bridge.cc (right):

https://codereview.chromium.org/2599673005/diff/80001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_bridge.cc:158:
min_instance_version, method_name_for_logging.c_str());
Same. Could you remove kMinInstanceVersion in activity_icon_loader.cc?

[commit-bot: I haz the power, 2017-01-04 20:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:04:03]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-01-04 20:38:36]

The CQ bit was checked by lhchavez@chromium.org to run a CQ dry run

[Luis Héctor Chávez, 2017-01-04 20:38:56]

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc
(right):

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc:32:
mojom::FileSystemInstance* GetFileSystemInstance(
On 2017/01/04 19:59:12, Yusuke Sato (ooo Dec 16 to 31) wrote:
> Can you define ARC_GET_MIN_VERSION_FOR_METHOD macro in
> components/arc/instance_holder.h and remove constants at L25-28?

Long term we should probably stop using the GetInstanceForVersion method since
it cannot generate the error string. I'll add TODOs for now.

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sync_arc_package_helper.cc (right):

https://codereview.chromium.org/2599673005/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sync_arc_package_helper.cc:187:
static_cast<FakeAppInstance*>(GET_INSTANCE_FOR_METHOD(
On 2017/01/04 19:59:12, Yusuke Sato (ooo Dec 16 to 31) wrote:
> (not related to your CL, so no reply needed but.. why static_cast needed
> here???)

It's not. Removed.

https://codereview.chromium.org/2599673005/diff/80001/components/arc/instance...
File components/arc/instance_holder.h (right):

https://codereview.chromium.org/2599673005/diff/80001/components/arc/instance...
components/arc/instance_holder.h:21: #define GET_INSTANCE_FOR_METHOD(holder,
method_name)            \
On 2017/01/04 19:59:12, Yusuke Sato (ooo Dec 16 to 31) wrote:
> nit: I'm a bit concerned about defining a macro without a prefix (e.g.
component
> name) in a header file. What about adding 'ARC' to the name? Maybe
> ARC_GET_INSTANCE_FOR_METHOD or GET_ARC_INSTANCE_FOR_METHOD. WDYT?

sgtm, used the former.

https://codereview.chromium.org/2599673005/diff/80001/components/arc/intent_h...
File components/arc/intent_helper/arc_intent_helper_bridge.cc (right):

https://codereview.chromium.org/2599673005/diff/80001/components/arc/intent_h...
components/arc/intent_helper/arc_intent_helper_bridge.cc:158:
min_instance_version, method_name_for_logging.c_str());
On 2017/01/04 19:59:13, Yusuke Sato (ooo Dec 16 to 31) wrote:
> Same. Could you remove kMinInstanceVersion in activity_icon_loader.cc?

Added TODO.

[commit-bot: I haz the power, 2017-01-04 20:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-04 20:45:41]

lgtm

[commit-bot: I haz the power, 2017-01-04 21:06:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 21:06:48]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2017-01-04 21:07:24]

The CQ bit was checked by lhchavez@chromium.org

[Luis Héctor Chávez, 2017-01-04 21:07:25]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
dmazzoni@chromium.org, afakhry@chromium.org, georgesak@chromium.org,
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2599673005/#ps120001
(title: "Addressed feedback")

[commit-bot: I haz the power, 2017-01-04 21:07:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 21:12:34]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483564044867620,
"parent_rev": "a166be89eab080474790543eee642a823361a23d", "commit_rev":
"913e5efb3691d846e7da1c3fb6b8c41016c2d980"}

[commit-bot: I haz the power, 2017-01-04 21:13:01]

Description was changed from

==========
arc: Use GET_INTERFACE_FOR_METHOD macro

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try
==========

to

==========
arc: Use GET_INTERFACE_FOR_METHOD macro

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Review-Url: https://codereview.chromium.org/2599673005
==========

[commit-bot: I haz the power, 2017-01-04 21:13:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2017-01-04 21:14:39]

Description was changed from

==========
arc: Use GET_INTERFACE_FOR_METHOD macro

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Review-Url: https://codereview.chromium.org/2599673005
==========

to

==========
arc: Use GET_INTERFACE_FOR_METHOD macro

Now that Mojo can generate the min_version information automatically,
migrate arc::InstanceHolder<T>::GetInterfaceForMethod() to
GET_INTERFACE_FOR_METHOD(), which does not require the explicit version
number to be passed.

BUG=649782
TEST=git try

Committed: https://crrev.com/0843b0c2e8dcb65871f1c2be55dcd1198124666a
Cr-Commit-Position: refs/heads/master@{#441464}
==========

[commit-bot: I haz the power, 2017-01-04 21:14:40]

Patchset 7 (id:??) landed as
https://crrev.com/0843b0c2e8dcb65871f1c2be55dcd1198124666a
Cr-Commit-Position: refs/heads/master@{#441464}