Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: components/arc/intent_helper/arc_intent_helper_bridge.cc

Issue 2599673005: arc: Use GET_INTERFACE_FOR_METHOD macro (Closed)
Patch Set: Addressed feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/instance_holder.h ('k') | components/arc/kiosk/arc_kiosk_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/intent_helper/arc_intent_helper_bridge.cc
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge.cc b/components/arc/intent_helper/arc_intent_helper_bridge.cc
index c29d25b75dc3747bc44fcc35536c37a0be440165..7d3d3a280a4b8024870a5e2d26aaf9cc49cf7afb 100644
--- a/components/arc/intent_helper/arc_intent_helper_bridge.cc
+++ b/components/arc/intent_helper/arc_intent_helper_bridge.cc
@@ -48,7 +48,7 @@ void ArcIntentHelperBridge::OnInstanceReady() {
DCHECK(thread_checker_.CalledOnValidThread());
ash::Shell::GetInstance()->set_link_handler_model_factory(this);
auto* instance =
- arc_bridge_service()->intent_helper()->GetInstanceForMethod("Init");
+ ARC_GET_INSTANCE_FOR_METHOD(arc_bridge_service()->intent_helper(), Init);
DCHECK(instance);
instance->Init(binding_.CreateInterfacePtrAndBind());
}
@@ -154,8 +154,9 @@ ArcIntentHelperBridge::GetIntentHelperInstanceWithErrorCode(
return nullptr;
}
- auto* instance = intent_helper_holder->GetInstanceForMethod(
- method_name_for_logging, min_instance_version);
+ // TODO(lhchavez): Stop calling GetInstanceForVersion() directly.
+ auto* instance = intent_helper_holder->GetInstanceForVersion(
+ min_instance_version, method_name_for_logging.c_str());
if (!instance) {
if (out_error_code)
*out_error_code = GetResult::FAILED_ARC_NOT_SUPPORTED;
« no previous file with comments | « components/arc/instance_holder.h ('k') | components/arc/kiosk/arc_kiosk_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698