Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8007)

Unified Diff: chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc

Issue 2599673005: arc: Use GET_INTERFACE_FOR_METHOD macro (Closed)
Patch Set: Addressed feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/arc/arc_app_utils.cc ('k') | components/arc/audio/arc_audio_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc b/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
index ca3dab2760d1afd6c5911ba97cddcac42039ba31..6674fcf689b7652be593a6ad98c3112142981f78 100644
--- a/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
+++ b/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
@@ -28,9 +28,6 @@ using ArcSyncItem = ArcPackageSyncableService::SyncItem;
constexpr int64_t kNoAndroidID = 0;
-constexpr uint32_t kUninstallPackageMinVersion = 2;
-constexpr uint32_t kInstallPackageMinVersion = 8;
-
std::unique_ptr<ArcSyncItem> CreateSyncItemFromSyncSpecifics(
const sync_pb::ArcPackageSpecifics& specifics) {
return base::MakeUnique<ArcSyncItem>(
@@ -405,8 +402,8 @@ void ArcPackageSyncableService::InstallPackage(const ArcSyncItem* sync_item) {
return;
}
- auto* instance = prefs_->app_instance_holder()->GetInstanceForMethod(
- "InstallPackage", kInstallPackageMinVersion);
+ auto* instance = ARC_GET_INSTANCE_FOR_METHOD(prefs_->app_instance_holder(),
+ InstallPackage);
if (!instance)
return;
@@ -427,8 +424,8 @@ void ArcPackageSyncableService::UninstallPackage(const ArcSyncItem* sync_item) {
return;
}
- auto* instance = prefs_->app_instance_holder()->GetInstanceForMethod(
- "UninstallPackage", kUninstallPackageMinVersion);
+ auto* instance = ARC_GET_INSTANCE_FOR_METHOD(prefs_->app_instance_holder(),
+ UninstallPackage);
if (!instance)
return;
« no previous file with comments | « chrome/browser/ui/app_list/arc/arc_app_utils.cc ('k') | components/arc/audio/arc_audio_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698