chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc - Issue 2599673005: arc: Use GET_INTERFACE_FOR_METHOD macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

Issue 2599673005: arc: Use GET_INTERFACE_FOR_METHOD macro (Closed)

Patch Set: Addressed feedback Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.cc ('k') | chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

diff --git a/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc b/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

index 6eb069e4097eb970f0c42a46df6eb6f624c6a68e..dc1c9e31ddff74ccb5ada8970f882e0bc013b197 100644

--- a/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

+++ b/chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

@@ -38,9 +38,10 @@ mojom::FileSystemInstance* GetFileSystemInstance(

LOG(ERROR) << "Failed to get ArcServiceManager.";

return nullptr;

}

+ // TODO(lhchavez): Stop calling GetInstanceForVersion() directly.

return arc_service_manager->arc_bridge_service()

->file_system()

- ->GetInstanceForMethod(method_name_for_logging, min_version);

+ ->GetInstanceForVersion(min_version, method_name_for_logging.c_str());

}

template <typename T>