arc: Use GET_INTERFACE_FOR_METHOD macro

chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 11 matching lines @@
 
 namespace {
 
 constexpr uint32_t kGetFileSizeVersion = 1;
 constexpr uint32_t kOpenFileToReadVersion = 1;
 constexpr uint32_t kGetDocumentVersion = 2;
 constexpr uint32_t kGetChildDocumentsVersion = 2;
 
 // Returns FileSystemInstance for the given |min_version|, if found.
 // Otherwise, nullptr.
 mojom::FileSystemInstance* GetFileSystemInstance(

[Yusuke Sato, 2017/01/04 19:59:12]

Can you define ARC_GET_MIN_VERSION_FOR_METHOD macro in
components/arc/instance_holder.h and remove constants at L25-28?

[Luis Héctor Chávez, 2017/01/04 20:38:56]

Long term we should probably stop using the GetInstanceForVersion method since
it cannot generate the error string. I'll add TODOs for now.

     const std::string& method_name_for_logging,
     uint32_t min_version) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   auto* arc_service_manager = arc::ArcServiceManager::Get();
   if (!arc_service_manager) {
     LOG(ERROR) << "Failed to get ArcServiceManager.";
     return nullptr;
   }
   return arc_service_manager->arc_bridge_service()
       ->file_system()
-      ->GetInstanceForMethod(method_name_for_logging, min_version);
+      ->GetInstanceForVersion(min_version, method_name_for_logging.c_str());
 }
 
 template <typename T>
 void PostToIOThread(const base::Callback<void(T)>& callback, T result) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(callback, base::Passed(std::move(result))));
 }
 
@@ skipping 87 matching lines @@
       base::Bind(
           &GetChildDocumentsOnUIThread, authority, parent_document_id,
           base::Bind(
               &PostToIOThread<base::Optional<std::vector<mojom::DocumentPtr>>>,
               callback)));
 }
 
 }  // namespace file_system_instance_util
 
 }  // namespace arc