Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2499)

Unified Diff: chrome/browser/task_manager/providers/arc/arc_process_task.cc

Issue 2599673005: arc: Use GET_INTERFACE_FOR_METHOD macro (Closed)
Patch Set: Addressed feedback Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/providers/arc/arc_process_task.cc
diff --git a/chrome/browser/task_manager/providers/arc/arc_process_task.cc b/chrome/browser/task_manager/providers/arc/arc_process_task.cc
index bc19b00ffdb1dfb9b4da9076fddb527215eeebfe..e0b44c0825700c1fce30a2f988aab6f9e4d6840d 100644
--- a/chrome/browser/task_manager/providers/arc/arc_process_task.cc
+++ b/chrome/browser/task_manager/providers/arc/arc_process_task.cc
@@ -21,8 +21,6 @@ namespace task_manager {
namespace {
-constexpr uint32_t kKillProcessMinInstanceVersion = 1;
-
base::string16 MakeTitle(const std::string& process_name,
arc::mojom::ProcessState process_state) {
int name_template = IDS_TASK_MANAGER_ARC_PREFIX;
@@ -136,11 +134,9 @@ bool ArcProcessTask::IsKillable() {
}
void ArcProcessTask::Kill() {
- auto* process_instance =
- arc::ArcServiceManager::Get()
- ->arc_bridge_service()
- ->process()
- ->GetInstanceForMethod("KillProcess", kKillProcessMinInstanceVersion);
+ auto* process_instance = ARC_GET_INSTANCE_FOR_METHOD(
+ arc::ArcServiceManager::Get()->arc_bridge_service()->process(),
+ KillProcess);
if (!process_instance)
return;
process_instance->KillProcess(nspid_, "Killed manually from Task Manager");
« no previous file with comments | « chrome/browser/sync/test/integration/sync_arc_package_helper.cc ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698