Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
Justin Donnelly
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, sdefresne+watch_chromium.org, Moe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed keyCode from FormActivityRegistered API. keyCode was not used anywhere and also deprecated: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode BUG=676340 Committed: https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7 Cr-Commit-Position: refs/heads/master@{#440511}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M ios/chrome/browser/autofill/autofill_agent.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm View 6 chunks +0 lines, -12 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ios/web/public/web_state/web_state_observer_bridge.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/web/web_state/js/resources/core.js View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 2 chunks +1 line, -8 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 2 chunks +36 lines, -0 lines 1 comment Download
M ios/web/web_state/web_state_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ios/web/web_state/web_state_observer.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge.mm View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2593283002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm File ios/web/web_state/ui/crw_web_controller_unittest.mm (right): https://codereview.chromium.org/2593283002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode804 ios/web/web_state/ui/crw_web_controller_unittest.mm:804: ExecuteJavaScript(@"document.dispatchEvent(new KeyboardEvent('keyup'));"); I tried to dispatch event with form ...
4 years ago (2016-12-22 00:21:30 UTC) #2
Justin Donnelly
+mahmadi as FYI since he'll be taking over as iOS autofill owner soon Nice! I ...
4 years ago (2016-12-22 19:44:54 UTC) #3
Eugene But (OOO till 7-30)
Thanks!
4 years ago (2016-12-22 21:12:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593283002/1
4 years ago (2016-12-22 21:12:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 21:33:33 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-22 21:38:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8fcf715e395fe6deada8461a5a8649da9eb53e7
Cr-Commit-Position: refs/heads/master@{#440511}

Powered by Google App Engine
This is Rietveld 408576698