Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: ios/web/public/web_state/web_state_observer_bridge.h

Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_ 5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_
6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_ 6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 didSubmitDocumentWithFormNamed:(const std::string&)formName 46 didSubmitDocumentWithFormNamed:(const std::string&)formName
47 userInitiated:(BOOL)userInitiated; 47 userInitiated:(BOOL)userInitiated;
48 48
49 // Invoked by WebStateObserverBridge::FormActivityRegistered. 49 // Invoked by WebStateObserverBridge::FormActivityRegistered.
50 // TODO(ios): Method should take data transfer object rather than parameters. 50 // TODO(ios): Method should take data transfer object rather than parameters.
51 - (void)webState:(web::WebState*)webState 51 - (void)webState:(web::WebState*)webState
52 didRegisterFormActivityWithFormNamed:(const std::string&)formName 52 didRegisterFormActivityWithFormNamed:(const std::string&)formName
53 fieldName:(const std::string&)fieldName 53 fieldName:(const std::string&)fieldName
54 type:(const std::string&)type 54 type:(const std::string&)type
55 value:(const std::string&)value 55 value:(const std::string&)value
56 keyCode:(int)keyCode
57 inputMissing:(BOOL)inputMissing; 56 inputMissing:(BOOL)inputMissing;
58 57
59 // Invoked by WebStateObserverBridge::FaviconUrlUpdated. 58 // Invoked by WebStateObserverBridge::FaviconUrlUpdated.
60 - (void)webState:(web::WebState*)webState 59 - (void)webState:(web::WebState*)webState
61 didUpdateFaviconURLCandidates: 60 didUpdateFaviconURLCandidates:
62 (const std::vector<web::FaviconURL>&)candidates; 61 (const std::vector<web::FaviconURL>&)candidates;
63 62
64 // Note: after |webStateDestroyed:| is invoked, the WebState being observed 63 // Note: after |webStateDestroyed:| is invoked, the WebState being observed
65 // is no longer valid. 64 // is no longer valid.
66 - (void)webStateDestroyed:(web::WebState*)webState; 65 - (void)webStateDestroyed:(web::WebState*)webState;
(...skipping 28 matching lines...) Expand all
95 web::PageLoadCompletionStatus load_completion_status) override; 94 web::PageLoadCompletionStatus load_completion_status) override;
96 void InsterstitialDismissed() override; 95 void InsterstitialDismissed() override;
97 void UrlHashChanged() override; 96 void UrlHashChanged() override;
98 void HistoryStateChanged() override; 97 void HistoryStateChanged() override;
99 void DocumentSubmitted(const std::string& form_name, 98 void DocumentSubmitted(const std::string& form_name,
100 bool user_initiated) override; 99 bool user_initiated) override;
101 void FormActivityRegistered(const std::string& form_name, 100 void FormActivityRegistered(const std::string& form_name,
102 const std::string& field_name, 101 const std::string& field_name,
103 const std::string& type, 102 const std::string& type,
104 const std::string& value, 103 const std::string& value,
105 int key_code,
106 bool input_missing) override; 104 bool input_missing) override;
107 void FaviconUrlUpdated(const std::vector<FaviconURL>& candidates) override; 105 void FaviconUrlUpdated(const std::vector<FaviconURL>& candidates) override;
108 void WebStateDestroyed() override; 106 void WebStateDestroyed() override;
109 void DidStartLoading() override; 107 void DidStartLoading() override;
110 void DidStopLoading() override; 108 void DidStopLoading() override;
111 109
112 private: 110 private:
113 base::WeakNSProtocol<id<CRWWebStateObserver>> observer_; 111 base::WeakNSProtocol<id<CRWWebStateObserver>> observer_;
114 DISALLOW_COPY_AND_ASSIGN(WebStateObserverBridge); 112 DISALLOW_COPY_AND_ASSIGN(WebStateObserverBridge);
115 }; 113 };
116 114
117 } // namespace web 115 } // namespace web
118 116
119 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_ 117 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_OBSERVER_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698