Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: ios/web/public/web_state/web_state_observer.h

Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/web_state/web_state_observer.h
diff --git a/ios/web/public/web_state/web_state_observer.h b/ios/web/public/web_state/web_state_observer.h
index d0b76cd98c7723ddf25564687af52a46422abd93..ca05867ab139aeb7f97f93913e38dbf65d42c69e 100644
--- a/ios/web/public/web_state/web_state_observer.h
+++ b/ios/web/public/web_state/web_state_observer.h
@@ -29,10 +29,6 @@ enum class PageLoadCompletionStatus : bool { SUCCESS = 0, FAILURE = 1 };
// load events from WebState.
class WebStateObserver {
public:
- // Key code associated to form events for which the key code is missing or
- // irrelevant.
- static int kInvalidFormKeyCode;
-
// Returns the web state associated with this observer.
WebState* web_state() const { return web_state_; }
@@ -77,12 +73,10 @@ class WebStateObserver {
// Called when the user is typing on a form field, with |error| indicating if
// there is any error when parsing the form field information.
- // |key_code| may be kInvalidFormKeyCode if there is no key code.
virtual void FormActivityRegistered(const std::string& form_name,
const std::string& field_name,
const std::string& type,
const std::string& value,
- int key_code,
bool input_missing) {}
// Invoked when new favicon URL candidates are received.

Powered by Google App Engine
This is Rietveld 408576698