[ios] Removed keyCode from FormActivityRegistered API.

ios/web/web_state/ui/crw_web_controller_unittest.mm

Index: ios/web/web_state/ui/crw_web_controller_unittest.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_unittest.mm b/ios/web/web_state/ui/crw_web_controller_unittest.mm
index 4f6fd359fc76fc97f930f4601647e7495affcd90..69c625caab90b490750f60b5a95c3da52fbbedf3 100644
--- a/ios/web/web_state/ui/crw_web_controller_unittest.mm
+++ b/ios/web/web_state/ui/crw_web_controller_unittest.mm
@@ -27,6 +27,7 @@
 #import "ios/web/public/web_state/ui/crw_native_content_provider.h"
 #import "ios/web/public/web_state/ui/crw_web_view_content_view.h"
 #include "ios/web/public/web_state/url_verification_constants.h"
+#include "ios/web/public/web_state/web_state_observer.h"
 #import "ios/web/test/web_test_with_web_controller.h"
 #import "ios/web/test/wk_web_view_crash_utils.h"
 #include "ios/web/web_state/blocked_popup_info.h"
@@ -771,6 +772,41 @@ TEST_F(CRWWebControllerNavigationTest, HTTPPassword) {
               web::SSLStatus::DISPLAYED_PASSWORD_FIELD_ON_HTTP);
 }
 
+// Real WKWebView is required for CRWWebControllerFormActivityTest.
+typedef web::WebTestWithWebController CRWWebControllerFormActivityTest;
+
+// Tests that keyup event correctly delivered to WebStateObserver.
+TEST_F(CRWWebControllerFormActivityTest, KeyUpEvent) {
+  // Observes and verifies FormActivityRegistered call.
+  class FormActivityObserver : public web::WebStateObserver {
+   public:
+    explicit FormActivityObserver(web::WebState* web_state)
+        : web::WebStateObserver(web_state) {}
+    bool form_activity_registered() const { return form_activity_registered_; }
+    // WebStateObserver overrides:
+    void FormActivityRegistered(const std::string& form_name,
+                                const std::string& field_name,
+                                const std::string& type,
+                                const std::string& value,
+                                bool input_missing) override {
+      EXPECT_EQ("keyup", type);
+      EXPECT_FALSE(input_missing);
+      form_activity_registered_ = true;
+    }
+
+   private:
+    bool form_activity_registered_ = false;
+  };
+  FormActivityObserver form_activity_observer(web_state());
+  FormActivityObserver& form_activity_observer_ref(form_activity_observer);
+
+  LoadHtml(@"<p></p>");
+  ExecuteJavaScript(@"document.dispatchEvent(new KeyboardEvent('keyup'));");

[Eugene But (OOO till 7-30), 2016/12/22 00:21:29]

I tried to dispatch event with form input target, but it was not delivered to
the document, so I can't test form_name, field_name and value.

+  base::test::ios::WaitUntilCondition(^{
+    return form_activity_observer_ref.form_activity_registered();
+  });
+}
+
 // Real WKWebView is required for CRWWebControllerJSExecutionTest.
 typedef web::WebTestWithWebController CRWWebControllerJSExecutionTest;