Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 9862aab3701fc9ce38c96ee4e17a1f0fe3c8dc12..723a8e67fab9d5172cfd59ede1f7be9ed14cb00b 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2903,7 +2903,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
std::string fieldName;
std::string type;
std::string value;
- int keyCode = web::WebStateObserver::kInvalidFormKeyCode;
bool inputMissing = false;
if (!message->GetString("formName", &formName) ||
!message->GetString("fieldName", &fieldName) ||
@@ -2912,14 +2911,8 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
inputMissing = true;
}
- double keyCodeAsDouble = 0;
- if (!message->GetDouble("keyCode", &keyCodeAsDouble) || keyCodeAsDouble < 0) {
- keyCode = web::WebStateObserver::kInvalidFormKeyCode;
- } else {
- keyCode = static_cast<int>(keyCodeAsDouble);
- }
_webStateImpl->OnFormActivityRegistered(formName, fieldName, type, value,
- keyCode, inputMissing);
+ inputMissing);
return YES;
}

Powered by Google App Engine
This is Rietveld 408576698