ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm - Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm

Issue 2593283002: [ios] Removed keyCode from FormActivityRegistered API. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/autofill/form_input_accessory_view_controller.mm ('k') | ios/chrome/browser/passwords/password_generation_agent_unittest.mm » ('j') | ios/web/web_state/ui/crw_web_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm

diff --git a/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm b/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm

index 68250b9e4c198689c9b45e4106d64a05d6371c3c..c44ad27d3bec13c3e8c90a8406c0c6a2fbb54260 100644

--- a/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm

+++ b/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm

@@ -285,8 +285,6 @@ TEST_F(FormSuggestionControllerTest,

fieldName:"field"

type:"type"

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

EXPECT_TRUE(GetSuggestionView(input_accessory_view_));

@@ -303,8 +301,6 @@ TEST_F(FormSuggestionControllerTest, FormActivityBlurShouldBeIgnored) {

fieldName:"field"

type:"blur" // blur!

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

EXPECT_FALSE(GetSuggestionView(input_accessory_view_));

}

@@ -320,8 +316,6 @@ TEST_F(FormSuggestionControllerTest,

fieldName:"field"

type:"type"

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

// The suggestions accessory view should be empty.

@@ -348,8 +342,6 @@ TEST_F(FormSuggestionControllerTest,

fieldName:"field"

type:"type"

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

// The providers should each be asked if they have suggestions for the

@@ -397,8 +389,6 @@ TEST_F(FormSuggestionControllerTest,

fieldName:"field"

type:"type"

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

// Since the first provider has suggestions available, it and only it

@@ -436,8 +426,6 @@ TEST_F(FormSuggestionControllerTest, SelectingSuggestionShouldNotifyDelegate) {

fieldName:"field"

type:"type"

value:"value"

- keyCode:web::WebStateObserver::

- kInvalidFormKeyCode

inputMissing:false];

// Selecting a suggestion should notify the delegate.