Remove broken targets from "all" and "gn_all", under Windows component builds.

Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds, due to duplicate symbol definitions.

BUG=676055
Committed: https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d
Cr-Commit-Position: refs/heads/master@{#440204}

[Wez, 2016-12-20 22:51:32]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-12-20 22:54:01]

wez@chromium.org changed reviewers:
+ brucedawson@chromium.org, rjkroege@chromium.org

[Wez, 2016-12-20 22:54:02]

brucedawson: PTAL wrt BUILD.gn OWNERS.

rjkroege: We could additionally make the target definitions conditional on
is_win || is_component_build, to remove them even from |all| builds - WDYT?

kylechar, dpranke: FYI :)

[rjkroege, 2016-12-20 22:56:29]

lgtm

[commit-bot: I haz the power, 2016-12-21 01:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:41:55]

Dry run: This issue passed the CQ dry run.

[Wez, 2016-12-21 02:11:33]

Description was changed from

==========
Remove broken targets from gn_all, under Windows component builds.

The media_service_unittests and mus_demo.service targets fail to link
under Windows component builds, due to duplicate symbol definitions.

BUG=676122,676055
==========

to

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests and mus_demo.service targets fail to link
under Windows component builds, due to duplicate symbol definitions.

BUG=676122,676055
==========

[Wez, 2016-12-21 02:14:24]

wez@chromium.org changed reviewers:
+ jrummell@chromium.org

[Wez, 2016-12-21 02:14:24]

+jrummell for media/ OWNERS

[Wez, 2016-12-21 02:14:29]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 02:14:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:45:18]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-21 17:17:24]

On 2016/12/21 02:14:24, Wez wrote:
> +jrummell for media/ OWNERS

I've got https://codereview.chromium.org/2598703002/ which should fix the
mus_demo problem when it lands.

[Wez, 2016-12-21 17:27:12]

On 2016/12/21 17:17:24, kylechar wrote:
> On 2016/12/21 02:14:24, Wez wrote:
> > +jrummell for media/ OWNERS
> 
> I've got https://codereview.chromium.org/2598703002/ which should fix the
> mus_demo problem when it lands.

Oh, brilliant. I'll remove it from this CL, then. Thanks!

[Wez, 2016-12-21 18:14:32]

Description was changed from

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests and mus_demo.service targets fail to link
under Windows component builds, due to duplicate symbol definitions.

BUG=676122,676055
==========

to

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds,
due to duplicate symbol definitions.

BUG=676055
==========

[Wez, 2016-12-21 18:15:02]

wez@chromium.org changed reviewers:
+ watk@chromium.org
- jrummell@chromium.org

[Wez, 2016-12-21 18:15:02]

-jrummell, +watk: PTAL

brucedawson: Ping!

[Wez, 2016-12-21 18:15:08]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 18:15:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-12-21 18:27:54]

lgtm - just needs word-wrapping fix.

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:155: # crbug.com/676055: media_service_unittests
currently fails to link in Windows component builds, so don't declare it,
otherwise the "all" target will still try to build it.
Word-wrap at 80 lines.

[watk, 2016-12-21 18:35:36]

lgtm

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:181: }  # if (!(is_win && is_component_build))
total nit, but since you're changing it anyway: this is usually written without
the "if()"

[Wez, 2016-12-21 18:38:59]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2016-12-21 18:39:00]

The CQ bit was checked by wez@chromium.org

[Wez, 2016-12-21 18:39:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org
Link to the patchset: https://codereview.chromium.org/2592853002/#ps40001
(title: "Leave mus_demo enabled")

[commit-bot: I haz the power, 2016-12-21 18:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-12-21 18:53:56]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[Wez, 2016-12-21 18:54:04]

FYI

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
File media/mojo/services/BUILD.gn (right):

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:155: # crbug.com/676055: media_service_unittests
currently fails to link in Windows component builds, so don't declare it,
otherwise the "all" target will still try to build it.
On 2016/12/21 18:27:54, brucedawson wrote:
> Word-wrap at 80 lines.

Done.

https://codereview.chromium.org/2592853002/diff/40001/media/mojo/services/BUI...
media/mojo/services/BUILD.gn:181: }  # if (!(is_win && is_component_build))
On 2016/12/21 18:35:36, watk wrote:
> total nit, but since you're changing it anyway: this is usually written
without
> the "if()"

That makes sense for preprocessor conditionals, but those end with an explicit
#endif, whereas a closing brace could end a conditional or some other form of
declaration. But OK, done.

[Wez, 2016-12-21 18:54:09]

The CQ bit was unchecked by wez@chromium.org

[Wez, 2016-12-21 18:54:09]

The CQ bit was checked by wez@chromium.org

[Wez, 2016-12-21 18:54:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, watk@chromium.org, brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2592853002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-12-21 18:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 20:36:24]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482346449530850,
"parent_rev": "c7ee496a4d09fdc8d4b72cb8791893fadbe32374", "commit_rev":
"3e2873b6b27d9fe7a34b5d1cc72a692549fdef98"}

[commit-bot: I haz the power, 2016-12-21 20:36:51]

Description was changed from

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds,
due to duplicate symbol definitions.

BUG=676055
==========

to

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds,
due to duplicate symbol definitions.

BUG=676055

Review-Url: https://codereview.chromium.org/2592853002
==========

[commit-bot: I haz the power, 2016-12-21 20:36:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-21 20:38:50]

Description was changed from

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds,
due to duplicate symbol definitions.

BUG=676055

Review-Url: https://codereview.chromium.org/2592853002
==========

to

==========
Remove broken targets from "all" and "gn_all", under Windows component builds.

The media_service_unittests target fails to link under Windows component builds,
due to duplicate symbol definitions.

BUG=676055

Committed: https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d
Cr-Commit-Position: refs/heads/master@{#440204}
==========

[commit-bot: I haz the power, 2016-12-21 20:38:51]

Patchset 4 (id:??) landed as
https://crrev.com/0ee841c7f7d1f08996ed6bfc71209395638e135d
Cr-Commit-Position: refs/heads/master@{#440204}