Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: media/mojo/services/BUILD.gn

Issue 2592853002: Remove broken targets from "all" and "gn_all", under Windows component builds. (Closed)
Patch Set: Address comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//media/media_options.gni") 5 import("//media/media_options.gni")
6 import("//services/service_manager/public/cpp/service.gni") 6 import("//services/service_manager/public/cpp/service.gni")
7 import("//services/service_manager/public/service_manifest.gni") 7 import("//services/service_manager/public/service_manifest.gni")
8 import("//testing/test.gni") 8 import("//testing/test.gni")
9 9
10 config("mojo_media_config") { 10 config("mojo_media_config") {
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 ":lib", 145 ":lib",
146 "//mojo/public/c/system", 146 "//mojo/public/c/system",
147 "//services/service_manager/public/cpp", 147 "//services/service_manager/public/cpp",
148 ] 148 ]
149 149
150 data_deps = [ 150 data_deps = [
151 ":media_manifest", 151 ":media_manifest",
152 ] 152 ]
153 } 153 }
154 154
155 test("media_service_unittests") { 155 # crbug.com/676055: media_service_unittests currently fails to link in Windows
156 testonly = true 156 # component builds, so don't declare it, otherwise the "all" target will still
157 # try to build it.
158 if (!(is_win && is_component_build)) {
159 test("media_service_unittests") {
160 testonly = true
157 161
158 sources = [ 162 sources = [
159 "media_service_unittest.cc", 163 "media_service_unittest.cc",
160 ] 164 ]
161 165
162 deps = [ 166 deps = [
163 "//media", 167 "//media",
164 "//media/base:test_support", 168 "//media/base:test_support",
165 "//media/mojo/clients", 169 "//media/mojo/clients",
166 "//media/mojo/common", 170 "//media/mojo/common",
167 "//media/mojo/interfaces", 171 "//media/mojo/interfaces",
168 "//services/service_manager/public/cpp:service_test_support", 172 "//services/service_manager/public/cpp:service_test_support",
169 "//services/service_manager/public/cpp/test:run_all_service_tests", 173 "//services/service_manager/public/cpp/test:run_all_service_tests",
170 "//testing/gmock", 174 "//testing/gmock",
171 "//testing/gtest", 175 "//testing/gtest",
172 ] 176 ]
173 177
174 data_deps = [ 178 data_deps = [
175 ":media", 179 ":media",
176 ":test_manifest", 180 ":test_manifest",
177 ] 181 ]
178 } 182 }
183 } # !(is_win && is_component_build)
179 184
180 service_manifest("media_manifest") { 185 service_manifest("media_manifest") {
181 name = "media" 186 name = "media"
182 source = "media_manifest.json" 187 source = "media_manifest.json"
183 } 188 }
184 189
185 service_manifest("test_manifest") { 190 service_manifest("test_manifest") {
186 name = "media_service_unittests" 191 name = "media_service_unittests"
187 source = "test_manifest.json" 192 source = "test_manifest.json"
188 } 193 }
189 194
190 test("media_pipeline_integration_unittests") { 195 test("media_pipeline_integration_unittests") {
191 testonly = true 196 testonly = true
192 197
193 deps = [ 198 deps = [
194 "//media/test:mojo_pipeline_integration_tests", 199 "//media/test:mojo_pipeline_integration_tests",
195 "//services/service_manager/public/cpp/test:run_all_service_tests", 200 "//services/service_manager/public/cpp/test:run_all_service_tests",
196 ] 201 ]
197 202
198 data_deps = [ 203 data_deps = [
199 ":media", 204 ":media",
200 ":pipeline_test_manifest", 205 ":pipeline_test_manifest",
201 ] 206 ]
202 } 207 }
203 208
204 service_manifest("pipeline_test_manifest") { 209 service_manifest("pipeline_test_manifest") {
205 name = "media_pipeline_integration_unittests" 210 name = "media_pipeline_integration_unittests"
206 source = "pipeline_test_manifest.json" 211 source = "pipeline_test_manifest.json"
207 } 212 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698