Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: BUILD.gn

Issue 2592853002: Remove broken targets from "all" and "gn_all", under Windows component builds. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ffb9200e2dd4a1bb8c5963bb90083a0dd8296551..38275c42fc8eb0cc66583f5df7ef57de12603e4d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -759,6 +759,12 @@ group("gn_only") {
"//ui/views/mus:views_mus_unittests",
]
+ # crbug.com/676055: media_service_unittests fails to link under Windows
+ # component builds, due to duplicate symbol definitions.
+ if (is_win && is_component_build) {
+ deps -= [ "//media/mojo/services:media_service_unittests" ]
+ }
+
if (use_ozone && is_chromeos) {
deps += [ "//services/ui/display:display_service_unittests" ]
}
« no previous file with comments | « no previous file | media/mojo/services/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698