Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2598703002: Fix linker error with mus_demo. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix linker error with mus_demo. In the Windows component build there is a linker error trying to compile //services/ui/demo:mus_demo. A symbol from //ui/compositor in the LayerOwner class can't be found. The aura::Window class inherits from LayerOwner which seems to be the root of the problem. Make the dep from //ui/aura to //ui/compositor a public dep. This is more appropriate than adding a dep from //services/ui/demo:mus_demo to //ui/compositor, as mus_demo doesn't include anything from //ui/compositor itself. BUG=676122 Committed: https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b Cr-Commit-Position: refs/heads/master@{#440165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/aura/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
kylechar
4 years ago (2016-12-21 17:16:23 UTC) #2
sadrul
lgtm
4 years ago (2016-12-21 17:18:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598703002/1
4 years ago (2016-12-21 17:19:03 UTC) #5
Wez
FWIW this deps change also appears to address crbug.com/654776, it seems. :)
4 years ago (2016-12-21 18:41:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 18:42:32 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e9015716f2cfdbce859c1239ff0d2ec93f74dc0b Cr-Commit-Position: refs/heads/master@{#440165}
4 years ago (2016-12-21 18:44:46 UTC) #12
Wez
4 years ago (2016-12-21 20:40:34 UTC) #13
Message was sent while issue was closed.
On 2016/12/21 18:41:39, Wez wrote:
> FWIW this deps change also appears to address crbug.com/654776, it seems. :)

Scratch that; some sort of build issue on my device, it seems. :(

Powered by Google App Engine
This is Rietveld 408576698