Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: BUILD.gn

Issue 2592853002: Remove broken targets from "all" and "gn_all", under Windows component builds. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/mojo/services/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 "//services/navigation", 752 "//services/navigation",
753 "//services/preferences:tests", 753 "//services/preferences:tests",
754 "//services/ui/demo", 754 "//services/ui/demo",
755 "//services/ui/demo:mus_demo_unittests", 755 "//services/ui/demo:mus_demo_unittests",
756 "//services/ui/public/interfaces:ui_struct_traits_unittests", 756 "//services/ui/public/interfaces:ui_struct_traits_unittests",
757 "//services/ui/ws:tests", 757 "//services/ui/ws:tests",
758 "//ui/views/mus:views_mus_interactive_ui_tests", 758 "//ui/views/mus:views_mus_interactive_ui_tests",
759 "//ui/views/mus:views_mus_unittests", 759 "//ui/views/mus:views_mus_unittests",
760 ] 760 ]
761 761
762 # crbug.com/676055: media_service_unittests fails to link under Windows
763 # component builds, due to duplicate symbol definitions.
764 if (is_win && is_component_build) {
765 deps -= [ "//media/mojo/services:media_service_unittests" ]
766 }
767
762 if (use_ozone && is_chromeos) { 768 if (use_ozone && is_chromeos) {
763 deps += [ "//services/ui/display:display_service_unittests" ] 769 deps += [ "//services/ui/display:display_service_unittests" ]
764 } 770 }
765 } 771 }
766 772
767 if (is_linux && !is_chromeos && !is_chromecast) { 773 if (is_linux && !is_chromeos && !is_chromecast) {
768 # TODO(GYP): Figure out if any of these should be in gn_all 774 # TODO(GYP): Figure out if any of these should be in gn_all
769 # and figure out how cross-platform they are 775 # and figure out how cross-platform they are
770 deps += [ 776 deps += [
771 ":gn_mojo_targets", 777 ":gn_mojo_targets",
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 assert(target_name != "") # Mark as used. 1099 assert(target_name != "") # Mark as used.
1094 sources = invoker.actual_sources 1100 sources = invoker.actual_sources
1095 assert( 1101 assert(
1096 sources == invoker.actual_sources, 1102 sources == invoker.actual_sources,
1097 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1103 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1098 } 1104 }
1099 1105
1100 assert_valid_out_dir("_unused") { 1106 assert_valid_out_dir("_unused") {
1101 actual_sources = [ "$root_build_dir/foo" ] 1107 actual_sources = [ "$root_build_dir/foo" ]
1102 } 1108 }
OLDNEW
« no previous file with comments | « no previous file | media/mojo/services/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698