Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: media/mojo/services/BUILD.gn

Issue 2592853002: Remove broken targets from "all" and "gn_all", under Windows component builds. (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index 162d435d7be2f0417a65e96cc294ff1e91960115..f64a5e1f0f8f4cd1c1c3275e5ec570e69b795677 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -152,30 +152,35 @@ service("media") {
]
}
-test("media_service_unittests") {
- testonly = true
-
- sources = [
- "media_service_unittest.cc",
- ]
+# crbug.com/676055: media_service_unittests currently fails to link in Windows
+# component builds, so don't declare it, otherwise the "all" target will still
+# try to build it.
+if (!(is_win && is_component_build)) {
+ test("media_service_unittests") {
+ testonly = true
+
+ sources = [
+ "media_service_unittest.cc",
+ ]
- deps = [
- "//media",
- "//media/base:test_support",
- "//media/mojo/clients",
- "//media/mojo/common",
- "//media/mojo/interfaces",
- "//services/service_manager/public/cpp:service_test_support",
- "//services/service_manager/public/cpp/test:run_all_service_tests",
- "//testing/gmock",
- "//testing/gtest",
- ]
+ deps = [
+ "//media",
+ "//media/base:test_support",
+ "//media/mojo/clients",
+ "//media/mojo/common",
+ "//media/mojo/interfaces",
+ "//services/service_manager/public/cpp:service_test_support",
+ "//services/service_manager/public/cpp/test:run_all_service_tests",
+ "//testing/gmock",
+ "//testing/gtest",
+ ]
- data_deps = [
- ":media",
- ":test_manifest",
- ]
-}
+ data_deps = [
+ ":media",
+ ":test_manifest",
+ ]
+ }
+} # !(is_win && is_component_build)
service_manifest("media_manifest") {
name = "media"
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698