Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)

Created:
4 years ago by Jay Civelli
Modified:
3 years, 12 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Making the ownership of parameters in BrowserChildProcessHost::Launch and ChildProcessLauncher::Launch() explicit. BUG=675294 Committed: https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7 Cr-Commit-Position: refs/heads/master@{#440333}

Patch Set 1 #

Patch Set 2 : Fixed bots. #

Patch Set 3 : Fixed Windows bots #

Patch Set 4 : More Win compilation fixes #

Patch Set 5 : Not using the try bots as my Windows compiler, I swear. #

Patch Set 6 : Clarifying the parameters ownership in ChildProcessLauncher::Launch() #

Patch Set 7 : Fixed crasher on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -68 lines) Patch
M components/nacl/browser/nacl_broker_host_win.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/child_process_launcher.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/child_process_launcher.cc View 1 2 3 4 9 chunks +20 lines, -20 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 6 11 chunks +19 lines, -16 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +6 lines, -4 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/public/browser/browser_child_process_host.h View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 41 (36 generated)
Jay Civelli
4 years ago (2016-12-17 01:27:29 UTC) #6
jam
lgtm
4 years ago (2016-12-19 19:06:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2585963002/120001
3 years, 12 months ago (2016-12-22 03:46:30 UTC) #36
commit-bot: I haz the power
Committed patchset #7 (id:120001)
3 years, 12 months ago (2016-12-22 03:52:27 UTC) #39
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 03:53:55 UTC) #41
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d20cc0bc639b07b29e1e50ae5f321fceb8a9daa7
Cr-Commit-Position: refs/heads/master@{#440333}

Powered by Google App Engine
This is Rietveld 408576698