components/nacl/browser/nacl_process_host.cc - Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)

Patch Set: Fixed crasher on Windows. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/browser/nacl_process_host.cc

diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc

index f8b471185caaffbc90ef8ba30cafe9f6ec4d0124..5cf4cf49752249589cb1e45f50bdf50ddda1bf8b 100644

--- a/components/nacl/browser/nacl_process_host.cc

+++ b/components/nacl/browser/nacl_process_host.cc

@@ -577,8 +577,8 @@ bool NaClProcessHost::LaunchSelLdr() {

return true;

}

#endif

- process_->Launch(new NaClSandboxedProcessLauncherDelegate(),

- cmd_line.release(), true);

+ process_->Launch(base::MakeUnique<NaClSandboxedProcessLauncherDelegate>(),

+ std::move(cmd_line), true);

return true;

}