Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2213)

Unified Diff: content/public/browser/browser_child_process_host.h

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)
Patch Set: Fixed crasher on Windows. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/utility_process_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_child_process_host.h
diff --git a/content/public/browser/browser_child_process_host.h b/content/public/browser/browser_child_process_host.h
index 7f8bb931ed12887a50d301d681723b01fa8fa20d..48c36195dc220bbcfa237302240b3b2065437001 100644
--- a/content/public/browser/browser_child_process_host.h
+++ b/content/public/browser/browser_child_process_host.h
@@ -58,10 +58,10 @@ class CONTENT_EXPORT BrowserChildProcessHost : public IPC::Sender {
~BrowserChildProcessHost() override {}
// Derived classes call this to launch the child process asynchronously.
- // Takes ownership of |cmd_line| and |delegate|.
- virtual void Launch(SandboxedProcessLauncherDelegate* delegate,
- base::CommandLine* cmd_line,
- bool terminate_on_shutdown) = 0;
+ virtual void Launch(
+ std::unique_ptr<SandboxedProcessLauncherDelegate> delegate,
+ std::unique_ptr<base::CommandLine> cmd_line,
+ bool terminate_on_shutdown) = 0;
virtual const ChildProcessData& GetData() const = 0;
« no previous file with comments | « content/browser/utility_process_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698