Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: content/browser/browser_child_process_host_impl.h

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)
Patch Set: Fixed crasher on Windows. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
6 #define CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 // instance. 62 // instance.
63 static void TerminateAll(); 63 static void TerminateAll();
64 64
65 // Copies kEnableFeatures and kDisableFeatures to the command line. Generates 65 // Copies kEnableFeatures and kDisableFeatures to the command line. Generates
66 // them from the FeatureList override state, to take into account overrides 66 // them from the FeatureList override state, to take into account overrides
67 // from FieldTrials. 67 // from FieldTrials.
68 static void CopyFeatureAndFieldTrialFlags(base::CommandLine* cmd_line); 68 static void CopyFeatureAndFieldTrialFlags(base::CommandLine* cmd_line);
69 69
70 // BrowserChildProcessHost implementation: 70 // BrowserChildProcessHost implementation:
71 bool Send(IPC::Message* message) override; 71 bool Send(IPC::Message* message) override;
72 void Launch(SandboxedProcessLauncherDelegate* delegate, 72 void Launch(std::unique_ptr<SandboxedProcessLauncherDelegate> delegate,
73 base::CommandLine* cmd_line, 73 std::unique_ptr<base::CommandLine> cmd_line,
74 bool terminate_on_shutdown) override; 74 bool terminate_on_shutdown) override;
75 const ChildProcessData& GetData() const override; 75 const ChildProcessData& GetData() const override;
76 ChildProcessHost* GetHost() const override; 76 ChildProcessHost* GetHost() const override;
77 base::TerminationStatus GetTerminationStatus(bool known_dead, 77 base::TerminationStatus GetTerminationStatus(bool known_dead,
78 int* exit_code) override; 78 int* exit_code) override;
79 std::unique_ptr<base::SharedPersistentMemoryAllocator> TakeMetricsAllocator() 79 std::unique_ptr<base::SharedPersistentMemoryAllocator> TakeMetricsAllocator()
80 override; 80 override;
81 void SetName(const base::string16& name) override; 81 void SetName(const base::string16& name) override;
82 void SetHandle(base::ProcessHandle handle) override; 82 void SetHandle(base::ProcessHandle handle) override;
83 std::string GetServiceRequestChannelToken() override; 83 std::string GetServiceRequestChannelToken() override;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 170
171 bool is_channel_connected_; 171 bool is_channel_connected_;
172 bool notify_child_disconnected_; 172 bool notify_child_disconnected_;
173 173
174 base::WeakPtrFactory<BrowserChildProcessHostImpl> weak_factory_; 174 base::WeakPtrFactory<BrowserChildProcessHostImpl> weak_factory_;
175 }; 175 };
176 176
177 } // namespace content 177 } // namespace content
178 178
179 #endif // CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_ 179 #endif // CONTENT_BROWSER_BROWSER_CHILD_PROCESS_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « components/nacl/browser/nacl_process_host.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698