Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: content/browser/child_process_launcher.h

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)
Patch Set: Fixed crasher on Windows. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_launcher.h
diff --git a/content/browser/child_process_launcher.h b/content/browser/child_process_launcher.h
index c7646bd84507875718f841ec0d6cf21905613761..8e1e1b319e33352c1c209f4de0c8ef495306f3dc 100644
--- a/content/browser/child_process_launcher.h
+++ b/content/browser/child_process_launcher.h
@@ -76,8 +76,8 @@ class CONTENT_EXPORT ChildProcessLauncher : public base::NonThreadSafe {
// is encountered when processing messages from the child process. This
// callback must be safe to call from any thread.
ChildProcessLauncher(
- SandboxedProcessLauncherDelegate* delegate,
- base::CommandLine* cmd_line,
+ std::unique_ptr<SandboxedProcessLauncherDelegate> delegate,
+ std::unique_ptr<base::CommandLine> cmd_line,
int child_process_id,
Client* client,
const std::string& mojo_child_token,
@@ -115,8 +115,8 @@ class CONTENT_EXPORT ChildProcessLauncher : public base::NonThreadSafe {
private:
// Posts a task to the launcher thread to do the actual work.
- void Launch(SandboxedProcessLauncherDelegate* delegate,
- base::CommandLine* cmd_line,
+ void Launch(std::unique_ptr<SandboxedProcessLauncherDelegate> delegate,
+ std::unique_ptr<base::CommandLine> cmd_line,
int child_process_id);
void UpdateTerminationStatus(bool known_dead);
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698