content/browser/browser_child_process_host_impl.h - Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_child_process_host_impl.h

Issue 2585963002: Clarifying the parameters ownership of BrowserChildProcessHost::Launch() (Closed)

Patch Set: Fixed crasher on Windows. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_child_process_host_impl.h

diff --git a/content/browser/browser_child_process_host_impl.h b/content/browser/browser_child_process_host_impl.h

index 08521db6dc064f4b1c80870ac2d6a2e3c41f87e4..9975dc1aa692912a76b37f63de7692c66e96091e 100644

--- a/content/browser/browser_child_process_host_impl.h

+++ b/content/browser/browser_child_process_host_impl.h

@@ -69,8 +69,8 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl

// BrowserChildProcessHost implementation:

bool Send(IPC::Message* message) override;

- void Launch(SandboxedProcessLauncherDelegate* delegate,

- base::CommandLine* cmd_line,

+ void Launch(std::unique_ptr<SandboxedProcessLauncherDelegate> delegate,

+ std::unique_ptr<base::CommandLine> cmd_line,

bool terminate_on_shutdown) override;

const ChildProcessData& GetData() const override;

ChildProcessHost* GetHost() const override;