Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use underscores to separate words in filenames in webkitpy. Reason: for consistency. Closely related CL: https://codereview.chromium.org/2064313003 This CL was made in the same way, for the same purpose, but renames the rest of the files in webkitpy, outside of the tool/ directory. In addition to renaming files, this change also handles pylint warnings by making additional changes or adding pylint disable pragma comments. Committed: https://crrev.com/7f1c6c95666d01a7bc149a844e3672e2c538844e Cr-Commit-Position: refs/heads/master@{#439540}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix check for attribute in output_capture.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -2739 lines) Patch
A + third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer.py View 8 chunks +14 lines, -15 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py View 14 chunks +19 lines, -43 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py View 1 chunk +0 lines, -329 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py View 1 chunk +0 lines, -280 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detection_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py View 1 chunk +0 lines, -162 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 1 chunk +0 lines, -132 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction.py View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/net/network_transaction_unittest.py View 3 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction.py View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py View 1 chunk +0 lines, -94 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/web.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs.py View 1 chunk +11 lines, -9 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/crash_logs_unittest.py View 2 chunks +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs_unittest.py View 1 chunk +0 lines, -120 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_testing.py View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_testing_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_utils.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/log_utils_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting.py View 1 chunk +0 lines, -230 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting_unittest.py View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils.py View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py View 1 chunk +0 lines, -128 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture.py View 1 2 chunks +8 lines, -2 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py View 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py View 3 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py View 2 chunks +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_mock.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo.py View 1 chunk +0 lines, -189 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +0 lines, -216 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/profiler_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/common/system/system_host_mock.py View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost.py View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/system/systemhost_mock.py View 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user.py View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/user_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/workspace_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/formatter/main.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/formatter/main_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/main_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/optparser_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
qyearsley
(This is a non-urgent CL.) https://codereview.chromium.org/2578213005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py (left): https://codereview.chromium.org/2578213005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py#oldcode269 third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py:269: As far as I ...
4 years ago (2016-12-17 18:58:57 UTC) #5
Dirk Pranke
lgtm https://codereview.chromium.org/2578213005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py File third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py (left): https://codereview.chromium.org/2578213005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py#oldcode269 third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/baseline_optimizer_unittest.py:269: On 2016/12/17 18:58:57, qyearsley wrote: > As far ...
4 years ago (2016-12-18 02:46:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578213005/1
4 years ago (2016-12-18 20:49:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/352227)
4 years ago (2016-12-18 22:10:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578213005/20001
4 years ago (2016-12-19 20:26:42 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 20:35:24 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-19 20:38:24 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f1c6c95666d01a7bc149a844e3672e2c538844e
Cr-Commit-Position: refs/heads/master@{#439540}

Powered by Google App Engine
This is Rietveld 408576698