third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Fix check for attribute in output_capture.py. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

index 9b9d624a58349cded3affc5c3f20f486b64c5097..dc254766812e8203a9a9cce60f03564d4f26b6ca 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py

@@ -31,15 +31,15 @@ class JSONChecker(object):

categories = set(('json/syntax',))

- def __init__(self, file_path, handle_style_error):

+ def __init__(self, _, handle_style_error):

self._handle_style_error = handle_style_error

self._handle_style_error.turn_off_line_filtering()

def check(self, lines):

try:

json.loads('\n'.join(lines) + '\n')

- except ValueError as e:

- self._handle_style_error(self.line_number_from_json_exception(e), 'json/syntax', 5, str(e))

+ except ValueError as error:

+ self._handle_style_error(self.line_number_from_json_exception(error), 'json/syntax', 5, str(error))

@staticmethod

def line_number_from_json_exception(error):