third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Fix check for attribute in output_capture.py. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

index 081ef3f7bea2e340c348299bd8d4115494a1620b..bbd820591c75ce8e232097c2def26bfbc6b94c5c 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

@@ -28,7 +28,7 @@

import optparse

-from webkitpy.common.system import outputcapture

+from webkitpy.common.system import output_capture

from webkitpy.common.system.executive_mock import MockExecutive

from webkitpy.layout_tests.port import port_testcase

from webkitpy.layout_tests.port import win

@@ -44,7 +44,7 @@ class WinPortTest(port_testcase.PortTestCase):

def test_setup_environ_for_server(self):

port = self.make_port()

port._executive = MockExecutive(should_log=True)

- output = outputcapture.OutputCapture()

+ output = output_capture.OutputCapture()

orig_environ = port.host.environ.copy()

env = output.assert_outputs(self, port.setup_environ_for_server)

self.assertEqual(orig_environ["PATH"], port.host.environ.get("PATH"))

@@ -59,7 +59,7 @@ class WinPortTest(port_testcase.PortTestCase):

port = self.make_port(options=optparse.Values({'register_cygwin': True, 'results_directory': '/'}))

port._executive = MockExecutive(should_log=True)

expected_logs = "MOCK run_command: ['/mock-checkout/third_party/cygwin/setup_mount.bat'], cwd=None\n"

- output = outputcapture.OutputCapture()

+ output = output_capture.OutputCapture()

output.assert_outputs(self, port.setup_environ_for_server, expected_logs=expected_logs)

def assert_name(self, port_name, os_version_string, expected):