Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2064313003: Rename files in webkitpy/tool to have underscores between words (for consistency). (Closed)

Created:
4 years, 6 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename files in webkitpy/tool to have underscores between words. Purpose: For consistency with other files in webkitpy. Files that are renamed in this CL: bot/commitannouncer.py -> ./bot/commit_announcer.py bot/commitannouncer_unittest.py -> ./bot/commit_announcer_unittest.py commands/abstractlocalservercommand.py -> ./commands/abstract_local_server_command.py commands/commandtest.py -> ./commands/command_test.py commands/commitannouncer.py -> ./commands/commit_announcer.py commands/flakytests.py -> ./commands/flaky_tests.py commands/flakytests_unittest.py -> ./commands/flaky_tests_unittest.py commands/helpcommand.py -> ./commands/help_command.py commands/layouttestsserver.py -> ./commands/layout_tests_server.py commands/prettydiff.py -> ./commands/pretty_diff.py commands/rebaselineserver.py -> ./commands/rebaseline_server.py mocktool.py -> ./mock_tool.py mocktool_unittest.py -> ./mock_tool_unittest.py multicommandtool.py -> ./multi_command_tool.py multicommandtool_unittest.py -> ./multi_command_tool_unittest.py servers/layouttestsserver.py -> ./servers/layout_tests_server.py servers/rebaselineserver.py -> ./servers/rebaseline_server.py servers/rebaselineserver_unittest.py -> ./servers/rebaseline_server_unittest.py servers/reflectionhandler.py -> ./servers/reflection_handler.py servers/reflectionhandler_unittest.py -> ./servers/reflection_handler_unittest.py This CL also fixes some pylint warnings in the files that are moved (in order to pass presubmit). Committed: https://crrev.com/ae33e67a1240b8bfb4b795decd20c61b6220a73e Cr-Commit-Position: refs/heads/master@{#400158}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2557 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer.py View 1 chunk +0 lines, -201 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commitannouncer_unittest.py View 1 chunk +0 lines, -205 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractlocalservercommand.py View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py View 1 chunk +3 lines, -2 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commandtest.py View 1 chunk +0 lines, -53 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commit_announcer.py View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py View 1 chunk +0 lines, -69 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py View 3 chunks +8 lines, -9 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py View 1 chunk +0 lines, -119 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py View 1 chunk +0 lines, -83 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/help_command.py View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/helpcommand.py View 1 chunk +0 lines, -84 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/layout_tests_server.py View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/layouttestsserver.py View 1 chunk +0 lines, -44 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/pretty_diff.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/prettydiff.py View 1 chunk +0 lines, -92 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py View 1 chunk +0 lines, -101 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool_unittest.py View 1 chunk +0 lines, -55 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool.py View 4 chunks +5 lines, -4 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/multi_command_tool_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py View 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py View 1 chunk +0 lines, -164 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layout_tests_server.py View 1 chunk +2 lines, -3 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py View 1 chunk +0 lines, -79 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server.py View 4 chunks +6 lines, -3 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server_unittest.py View 4 chunks +17 lines, -13 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py View 1 chunk +0 lines, -282 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py View 1 chunk +0 lines, -317 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler.py View 2 chunks +7 lines, -2 lines 0 comments Download
A + third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py View 2 chunks +5 lines, -4 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py View 1 chunk +0 lines, -103 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
qyearsley
4 years, 6 months ago (2016-06-15 18:39:24 UTC) #3
Dirk Pranke
rs lgtm.
4 years, 6 months ago (2016-06-15 22:42:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064313003/1
4 years, 6 months ago (2016-06-15 22:59:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/21682) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-15 23:02:47 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064313003/20001
4 years, 6 months ago (2016-06-16 01:21:40 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-16 03:16:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064313003/20001
4 years, 6 months ago (2016-06-16 15:20:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 15:26:32 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 15:26:42 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:27:54 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae33e67a1240b8bfb4b795decd20c61b6220a73e
Cr-Commit-Position: refs/heads/master@{#400158}

Powered by Google App Engine
This is Rietveld 408576698