third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Fix check for attribute in output_capture.py. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py

similarity index 90%

rename from third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py

rename to third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py

index c7de905f21fcbeeb63e8ddf3610c0f6341bfb21e..05f3e329383b977349ec01972d32158617ed70b5 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputcapture_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/output_capture_unittest.py

@@ -23,7 +23,7 @@

import logging

import unittest

-from webkitpy.common.system.outputcapture import OutputCapture

+from webkitpy.common.system.output_capture import OutputCapture

_log = logging.getLogger(__name__)

@@ -40,7 +40,7 @@ class OutputCaptureTest(unittest.TestCase):

_log.error('ERROR')

_log.critical('CRITICAL')

- def assertLogged(self, expected_logs):

+ def assert_logged(self, expected_logs):

actual_stdout, actual_stderr, actual_logs = self.output.restore_output()

self.assertEqual('', actual_stdout)

self.assertEqual('', actual_stderr)

@@ -49,7 +49,7 @@ class OutputCaptureTest(unittest.TestCase):

def test_initial_log_level(self):

self.output.capture_output()

self.log_all_levels()

- self.assertLogged('INFO\nWARN\nERROR\nCRITICAL\n')

+ self.assert_logged('INFO\nWARN\nERROR\nCRITICAL\n')

def test_set_log_level(self):

self.output.set_log_level(logging.ERROR)

@@ -57,4 +57,4 @@ class OutputCaptureTest(unittest.TestCase):

self.log_all_levels()

self.output.set_log_level(logging.WARN)

self.log_all_levels()

- self.assertLogged('ERROR\nCRITICAL\nWARN\nERROR\nCRITICAL\n')

+ self.assert_logged('ERROR\nCRITICAL\nWARN\nERROR\nCRITICAL\n')