third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py - Issue 2578213005: Use underscores to separate words in filenames in webkitpy.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results.py

Issue 2578213005: Use underscores to separate words in filenames in webkitpy. (Closed)

Patch Set: Fix check for attribute in output_capture.py. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/layout_test_results_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2010, Google Inc. All rights reserved.	1 # Copyright (c) 2010, Google Inc. All rights reserved.

2 #	2 #

3 # Redistribution and use in source and binary forms, with or without	3 # Redistribution and use in source and binary forms, with or without

4 # modification, are permitted provided that the following conditions are	4 # modification, are permitted provided that the following conditions are

5 # met:	5 # met:

6 #	6 #

7 # * Redistributions of source code must retain the above copyright	7 # * Redistributions of source code must retain the above copyright

8 # notice, this list of conditions and the following disclaimer.	8 # notice, this list of conditions and the following disclaimer.

9 # * Redistributions in binary form must reproduce the above	9 # * Redistributions in binary form must reproduce the above

10 # copyright notice, this list of conditions and the following disclaimer	10 # copyright notice, this list of conditions and the following disclaimer

(...skipping 142 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
153 def add_if_passes(result):	153 def add_if_passes(result):

154 if result_filter(result):	154 if result_filter(result):

155 results.append(result)	155 results.append(result)

156	156

157 LayoutTestResults._for_each_test(self._test_result_tree(), add_if_passes )	157 LayoutTestResults._for_each_test(self._test_result_tree(), add_if_passes )

158 return sorted(results, key=lambda r: r.test_name())	158 return sorted(results, key=lambda r: r.test_name())

159	159

160 def didnt_run_as_expected_results(self):	160 def didnt_run_as_expected_results(self):

161 # TODO(qyearsley): Rename this method.	161 # TODO(qyearsley): Rename this method.

162 return self._filter_tests(lambda r: not r.did_run_as_expected())	162 return self._filter_tests(lambda r: not r.did_run_as_expected())

OLD	NEW