DevTools: enable private field checks as a part of compilation.

DevTools: enable private field checks as a part of compilation.

Committed: https://crrev.com/2d6dcff9ac896f34b48945276029371eacbecc6a
Cr-Commit-Position: refs/heads/master@{#438085}

[pfeldman, 2016-12-12 23:30:25]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-12-12 23:41:37]

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js
(right):

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js:163: var
calculator = this.calculator();
Why is it var, not const? I don't see it's changed anywhere.

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
(right):

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js:106: *
@protected
@return plz

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1259:
this.createCells(element);
You can do it in a single line.

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js
(right):

https://codereview.chromium.org/2573673002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js:310:
var element = this.createElement();
You don't need to create an element if there's already one.

[pfeldman, 2016-12-12 23:54:56]

all done, except for the const one.

[alph, 2016-12-13 00:10:56]

The CQ bit was checked by alph@chromium.org

[alph, 2016-12-13 00:10:57]

lgtm

[commit-bot: I haz the power, 2016-12-13 00:12:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:54:49]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pfeldman1, 2016-12-13 05:04:22]

The CQ bit was checked by pfeldman@google.com

[commit-bot: I haz the power, 2016-12-13 05:04:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:46:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481605462363100,
"parent_rev": "5154772cfe14a0a6cb3b1e6fc3fb9c9916f200d8", "commit_rev":
"71f8c0049c28a7d914ae56c82e76e1d6f3b8f09e"}

[commit-bot: I haz the power, 2016-12-13 06:47:03]

Description was changed from

==========
DevTools: enable private field checks as a part of compilation.
==========

to

==========
DevTools: enable private field checks as a part of compilation.

Review-Url: https://codereview.chromium.org/2573673002
==========

[commit-bot: I haz the power, 2016-12-13 06:47:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 06:48:34]

Description was changed from

==========
DevTools: enable private field checks as a part of compilation.

Review-Url: https://codereview.chromium.org/2573673002
==========

to

==========
DevTools: enable private field checks as a part of compilation.

Committed: https://crrev.com/2d6dcff9ac896f34b48945276029371eacbecc6a
Cr-Commit-Position: refs/heads/master@{#438085}
==========

[commit-bot: I haz the power, 2016-12-13 06:48:36]

Patchset 2 (id:??) landed as
https://crrev.com/2d6dcff9ac896f34b48945276029371eacbecc6a
Cr-Commit-Position: refs/heads/master@{#438085}