Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)
Patch Set: review comments addressed. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
index 3e67015dfd2cbf793fc79ecf32dc0d3b07b85b48..9534f7f6822c46701146c183d96f285e9c791efb 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
@@ -1255,14 +1255,15 @@ UI.DataGridNode = class extends Common.Object {
*/
element() {
if (!this._element) {
- this.createElement();
- this.createCells();
+ var element = this.createElement();
+ this.createCells(element);
}
return /** @type {!Element} */ (this._element);
}
/**
* @protected
+ * @return {!Element}
*/
createElement() {
this._element = createElement('tr');
@@ -1276,17 +1277,33 @@ UI.DataGridNode = class extends Common.Object {
this._element.classList.add('selected');
if (this.revealed)
this._element.classList.add('revealed');
+ return this._element;
+ }
+
+ /**
+ * @return {?Element}
+ */
+ existingElement() {
+ return this._element || null;
+ }
+
+ /**
+ * @protected
+ */
+ resetElement() {
+ this._element = null;
}
/**
+ * @param {!Element} element
* @protected
*/
- createCells() {
- this._element.removeChildren();
+ createCells(element) {
+ element.removeChildren();
var columnsArray = this.dataGrid._visibleColumnsArray;
for (var i = 0; i < columnsArray.length; ++i)
- this._element.appendChild(this.createCell(columnsArray[i].id));
- this._element.appendChild(this._createTDWithClass('corner'));
+ element.appendChild(this.createCell(columnsArray[i].id));
+ element.appendChild(this._createTDWithClass('corner'));
}
/**
@@ -1439,7 +1456,7 @@ UI.DataGridNode = class extends Common.Object {
this._element = null;
if (!this._element)
return;
- this.createCells();
+ this.createCells(this._element);
}
/**

Powered by Google App Engine
This is Rietveld 408576698