third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java - Issue 2573673002: DevTools: enable private field checks as a part of compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)

Patch Set: review comments addressed. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

diff --git a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java b/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

index 84288376573eb6a7517560066bf19e751d93e2c6..a238589037377f7f0a86753adb5b4ecbb3de6b90 100644

--- a/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

+++ b/third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

@@ -11,7 +11,7 @@ public class DevToolsCodingConvention extends CodingConventions.Proxy {

@Override

public boolean isPrivate(String name) {

- return false; // name.length() > 1 && name.charAt(0) == '_' && name.charAt(1) != '_';

+ return name.length() > 1 && name.charAt(0) == '_' && name.charAt(1) != '_';

}

@Override

« no previous file with comments | « third_party/WebKit/Source/devtools/scripts/closure/closure_runner/closure_runner.jar ('k') | no next file » | no next file with comments »