third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js - Issue 2573673002: DevTools: enable private field checks as a part of compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)

Patch Set: review comments addressed. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

index dc001513250860e69f37dcec5f081d3d9a776ce5..f7a634aeba104861aa23158b3b1cc2df6a7b511e 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

@@ -212,15 +212,15 @@ Network.ResourceWebSocketFrameNode = class extends UI.SortableDataGridNode {

/**

* @override

+ * @param {!Element} element

- createCells() {

- var element = this._element;

+ createCells(element) {

element.classList.toggle(

'websocket-frame-view-row-error', this._frame.type === SDK.NetworkRequest.WebSocketFrameType.Error);

element.classList.toggle(

'websocket-frame-view-row-outcoming', this._frame.type === SDK.NetworkRequest.WebSocketFrameType.Send);

element.classList.toggle('websocket-frame-view-row-opcode', !this._isTextFrame);

- super.createCells();

+ super.createCells(element);

}

/**