third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2573673002: DevTools: enable private field checks as a part of compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)

Patch Set: review comments addressed. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/module.json ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index ebf5b7a00da2f0f5e577d87cf1260f2e95df8e19..e62d3fb47c9a37582dc2be94b2989415f41c7d3a 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -287,14 +287,15 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {

/**

* @override

+ * @param {!Element} element

- createCells() {

+ createCells(element) {

this._nameCell = null;

this._initiatorCell = null;

- this._element.classList.toggle('network-error-row', this._isFailed());

- this._element.classList.toggle('network-navigation-row', this._isNavigationRequest);

- super.createCells();

+ element.classList.toggle('network-error-row', this._isFailed());

+ element.classList.toggle('network-navigation-row', this._isNavigationRequest);

+ super.createCells(element);

}

/**