third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js - Issue 2573673002: DevTools: enable private field checks as a part of compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 2573673002: DevTools: enable private field checks as a part of compilation. (Closed)

Patch Set: review comments addressed. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

index 45b18d3222c8b1d23b8d02e812584cea6b08e761..5408a32cd8c7932f6772ff46589645b17ff50b53 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

@@ -528,7 +528,7 @@ Timeline.TimelineFilmStripOverview = class extends Timeline.TimelineEventOvervie

if (!this._filmStripModel.frames().length)

return Promise.resolve(/** @type {?Element} */ (null));

- var time = this._calculator.positionToTime(x);

+ var time = this.calculator().positionToTime(x);

var frame = this._filmStripModel.frameByTimestamp(time);

if (frame === this._lastFrame)

return Promise.resolve(this._lastElement);