[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Committed: https://crrev.com/b313bcac825d7be7741d7923e9074a93a42f72d7
Cr-Commit-Position: refs/heads/master@{#438562}

[cbiesinger, 2016-12-13 20:38:01]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 20:38:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-12-13 20:47:33]

LGTM

Thanks Christian!

[cbiesinger, 2016-12-13 20:50:09]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-12-13 20:50:13]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-12-13 20:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:31:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:31:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger, 2016-12-13 21:44:55]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-12-13 21:44:56]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2571893002/#ps20001
(title: "revert back to manually re-setting m_hasDefiniteHeight and moving it
before updateAfterLayout, beca…")

[commit-bot: I haz the power, 2016-12-13 21:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 23:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 23:33:17]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2016-12-14 16:55:42]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-12-14 16:55:42]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2571893002/#ps40001
(title: "Switch back to computePercentageLogicalHeight from
hasDefiniteLogicalHeight to fix test failures")

[cbiesinger, 2016-12-14 16:55:56]

Description was changed from

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

Additionally this patch uses AutoReset for m_hasDefiniteHeight instead of a
manual reset & uses hasDefiniteLogicalHeight() to compute whether we have
a definite height. These two changes should not change behavior.

BUG=669714
R=eae@chromium.org
==========

to

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org
==========

[commit-bot: I haz the power, 2016-12-14 16:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:57:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481734542066930,
"parent_rev": "8e9d42ade07f35da948afb7d2112a48ef9480a3a", "commit_rev":
"0283d45c441d1ba91301f1d3c22ee0b042d295d4"}

[commit-bot: I haz the power, 2016-12-14 18:57:25]

Description was changed from

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org
==========

to

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2571893002
==========

[commit-bot: I haz the power, 2016-12-14 18:57:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-14 18:59:59]

Description was changed from

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2571893002
==========

to

==========
[css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Fixes a regression from https://codereview.chromium.org/2056043002

It is possible that we get into mainAxisLengthIsDefinite outside of layout,
especially via mainSizeForPercentageResolution. But in that case we do not want
to cache the value we compute because we have no way to invalidate it
correctly. So this patch introduces a m_inLayout variable to store this
correctly. (An alternative would be to set m_hasDefiniteHeight at the beginning
of layout and otherwise just read from it, but then we would need to always
compute it even if it turns out to be unneeded. Let me know if you prefer that
though.)

BUG=669714
R=eae@chromium.org

Committed: https://crrev.com/b313bcac825d7be7741d7923e9074a93a42f72d7
Cr-Commit-Position: refs/heads/master@{#438562}
==========

[commit-bot: I haz the power, 2016-12-14 19:00:00]

Patchset 3 (id:??) landed as
https://crrev.com/b313bcac825d7be7741d7923e9074a93a42f72d7
Cr-Commit-Position: refs/heads/master@{#438562}