third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h - Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock() (Closed)

Patch Set: Switch back to computePercentageLogicalHeight from hasDefiniteLogicalHeight to fix test failures Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

index 396a5262e1d04ecaadcd06b4c8c74d6631aa0db0..ddb6f03f5b12f8b4f84a198e2d0cdaa77d546d88 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

@@ -254,6 +254,7 @@ class CORE_EXPORT LayoutFlexibleBox : public LayoutBlock {

// This is SizeIsUnknown outside of layoutBlock()

mutable SizeDefiniteness m_hasDefiniteHeight;

+ bool m_inLayout;

};

DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox());