third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html - Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html

Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock() (Closed)

Patch Set: Switch back to computePercentageLogicalHeight from hasDefiniteLogicalHeight to fix test failures Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <style>

	4 html { line-height: 1; font-size: 18px; }

	5 #relpos { position: relative; top: 1px; }

	6 .flex { flex: 1; }

	7 .flex { min-height: 0; }

	8 .layout, .layout-column, .layout-row { display: flex; }

	9 .layout-column { flex-direction: column; }

	10 </style>

	11

	12 <script src="../../resources/testharness.js"></script>

	13 <script src="../../resources/testharnessreport.js"></script>

	14 <script src="../../resources/check-layout-th.js"></script>

	15

	16 <script>

	17 function update() {

	18 document.body.offsetHeight;

	19 document.getElementById("relpos").innerText = " ";

	20 checkLayout("#container");

	21 }

	22 </script>

	23

	24 <body onload="update();">

	25 <p>XXX and YYY should be on separate lines and not overlap, i.e. the height of

	26 .flex should not be 0.</p>

	27 <div class="layout-column" id="container">

	28 <div class="layout-row">

	29 <div class="layout-column">

	30 <div class="flex" data-expected-height="18">XXX<span id="relpos"></span> </div>

	31 <div>YYY</div>

	32 </div>

	33 </div>

	34 </div>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h » ('j') | no next file with comments »