third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html - Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html

Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock() (Closed)

Patch Set: Switch back to computePercentageLogicalHeight from hasDefiniteLogicalHeight to fix test failures Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html

diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html b/third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html

new file mode 100644

index 0000000000000000000000000000000000000000..243a96494da9193bfa9194b6c5780630f80f07bc

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/css3/flexbox/bug669714.html

@@ -0,0 +1,34 @@

+<!DOCTYPE html>

+<style>

+html { line-height: 1; font-size: 18px; }

+#relpos { position: relative; top: 1px; }

+.flex { flex: 1; }

+.flex { min-height: 0; }

+.layout, .layout-column, .layout-row { display: flex; }

+.layout-column { flex-direction: column; }

+</style>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<script src="../../resources/check-layout-th.js"></script>

+<script>

+function update() {

+ document.body.offsetHeight;

+ document.getElementById("relpos").innerText = " ";

+ checkLayout("#container");

+</script>

+<body onload="update();">

+<p>XXX and YYY should be on separate lines and not overlap, i.e. the height of

+.flex should not be 0.</p>

+<div class="layout-column" id="container">

+ <div class="layout-row">

+ <div class="layout-column">

+ <div class="flex" data-expected-height="18">XXX<span id="relpos"></span></div>

+ <div>YYY</div>

+ </div>

+</div>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h » ('j') | no next file with comments »