[css-flexbox] Cache whether our main axis size is definite

[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792
Committed: https://crrev.com/7f6ee2762d0e5617c17ad828d6353424ca59bacd
Cr-Commit-Position: refs/heads/master@{#404969}

[cbiesinger, 2016-06-09 22:05:01]

Description was changed from

==========
flexbox performance

BUG=595361
==========

to

==========
flexbox performance

BUG=595361,617792
==========

[cbiesinger, 2016-07-06 22:58:35]

Description was changed from

==========
flexbox performance

BUG=595361,617792
==========

to

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=595361,617792
==========

[cbiesinger, 2016-07-06 22:58:35]

cbiesinger@chromium.org changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[cbiesinger, 2016-07-06 22:58:52]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:59:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-07-06 23:06:09]

https://codereview.chromium.org/2056043002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):

https://codereview.chromium.org/2056043002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:205: int
m_hasDefiniteHeight = -1;
Use an enum for this. You might also want to pack it with
m_numberOfInFlowChildrenOnFirstLine.

[cbiesinger, 2016-07-06 23:19:47]

On 2016/07/06 23:06:09, eae wrote:
>
https://codereview.chromium.org/2056043002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):
> 
>
https://codereview.chromium.org/2056043002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:205: int
> m_hasDefiniteHeight = -1;
> Use an enum for this. You might also want to pack it with
> m_numberOfInFlowChildrenOnFirstLine.

Done, PTAL. Lint did not like my attempt to make this a bitfield but I did make
it an enum class.

[eae, 2016-07-06 23:21:50]

Thanks, LGTM!

[cbiesinger, 2016-07-06 23:22:24]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:23:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:15:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[cbiesinger, 2016-07-07 00:20:37]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:21:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 01:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 01:04:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[cbiesinger1, 2016-07-07 01:12:10]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2016-07-07 01:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 02:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 02:25:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger1, 2016-07-07 03:20:41]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2016-07-07 03:20:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 04:17:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 04:17:29]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2016-07-07 15:01:04]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-07-07 15:01:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-07-07 15:52:53]

OK, looks like there are a couple of real failures:

fast/repaint/video-unmute-repaint.html
fast/repaint/video-mute-repaint.html

Looking.

[cbiesinger, 2016-07-07 15:53:09]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-07-07 17:43:16]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 17:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-07-07 17:44:41]

Emil: I'm doing this slightly differently now, do you want to take another look?

[cbiesinger, 2016-07-07 17:46:55]

Nevermind, that doesn't seem to work either :(

[cbiesinger, 2016-07-07 18:25:28]

The CQ bit was unchecked by cbiesinger@chromium.org

[cbiesinger, 2016-07-07 19:43:49]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 19:44:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-07-07 21:13:25]

Emil: The try servers like this version now -- it's slightly different than the
original version. I like it better, too. Do you want to take another look?

[commit-bot: I haz the power, 2016-07-07 21:40:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:40:17]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-07-08 16:54:58]

Description was changed from

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=595361,617792
==========

to

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792
==========

[eae, 2016-07-12 16:34:46]

Still looks good. CQ+

[eae, 2016-07-12 16:34:54]

The CQ bit was checked by eae@chromium.org

[eae, 2016-07-12 16:34:55]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2056043002/#ps120001
(title: "different approach")

[commit-bot: I haz the power, 2016-07-12 16:36:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:05:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger, 2016-07-12 18:58:46]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 01:07:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cbiesinger, 2016-07-13 01:08:09]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-07-13 01:09:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 03:38:46]

Description was changed from

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792
==========

to

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792
==========

[commit-bot: I haz the power, 2016-07-13 03:38:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-13 03:39:21]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 03:42:07]

Description was changed from

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792
==========

to

==========
[css-flexbox] Cache whether our main axis size is definite

This is an important performance optimization on pages
that have a lot of percentage-sized descendants of flexboxes.

TEST=n/a, no change in behavior
BUG=617792

Committed: https://crrev.com/7f6ee2762d0e5617c17ad828d6353424ca59bacd
Cr-Commit-Position: refs/heads/master@{#404969}
==========

[commit-bot: I haz the power, 2016-07-13 03:42:08]

Patchset 7 (id:??) landed as
https://crrev.com/7f6ee2762d0e5617c17ad828d6353424ca59bacd
Cr-Commit-Position: refs/heads/master@{#404969}