Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 2571893002: [css-flexbox] Only cache m_hasDefiniteHeight if we're inside of layoutBlock() (Closed)
Patch Set: Switch back to computePercentageLogicalHeight from hasDefiniteLogicalHeight to fix test failures Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 // need an additional layout pass for correct stretch alignment handling, as 247 // need an additional layout pass for correct stretch alignment handling, as
248 // the first layout likely did not use the correct value for percentage 248 // the first layout likely did not use the correct value for percentage
249 // sizing of children. 249 // sizing of children.
250 HashSet<const LayoutObject*> m_relaidOutChildren; 250 HashSet<const LayoutObject*> m_relaidOutChildren;
251 251
252 mutable OrderIterator m_orderIterator; 252 mutable OrderIterator m_orderIterator;
253 int m_numberOfInFlowChildrenOnFirstLine; 253 int m_numberOfInFlowChildrenOnFirstLine;
254 254
255 // This is SizeIsUnknown outside of layoutBlock() 255 // This is SizeIsUnknown outside of layoutBlock()
256 mutable SizeDefiniteness m_hasDefiniteHeight; 256 mutable SizeDefiniteness m_hasDefiniteHeight;
257 bool m_inLayout;
257 }; 258 };
258 259
259 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox()); 260 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutFlexibleBox, isFlexibleBox());
260 261
261 } // namespace blink 262 } // namespace blink
262 263
263 #endif // LayoutFlexibleBox_h 264 #endif // LayoutFlexibleBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698