Remove ScopedVector from PasswordStoreMac

Remove ScopedVector from PasswordStoreMac

BUG=555132
Committed: https://crrev.com/3a570aa0a8002d34d7e9327ffcd802b1bb7e96ac
Cr-Commit-Position: refs/heads/master@{#438093}

[vabr (Chromium), 2016-12-11 18:24:49]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 18:25:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-12-11 18:54:03]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 18:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 19:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 19:12:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2016-12-11 19:20:03]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 19:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-12-11 19:37:20]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 19:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 20:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 20:29:18]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-12-12 06:58:06]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2016-12-12 06:58:07]

Hi Vasilii,

Please review (and say goodbye to ScopedVector in password manager code :)).

Cheers,
Vaclav

[vasilii, 2016-12-12 10:09:21]

lgtm

Goodbye!

https://codereview.chromium.org/2566873002/diff/60001/chrome/browser/password...
File chrome/browser/password_manager/password_store_mac.cc (right):

https://codereview.chromium.org/2566873002/diff/60001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.cc:204: std::inserter(*first,
first->end()));
std::back_inserter?

[vabr (Chromium), 2016-12-12 11:18:17]

Thanks!

https://codereview.chromium.org/2566873002/diff/60001/chrome/browser/password...
File chrome/browser/password_manager/password_store_mac.cc (right):

https://codereview.chromium.org/2566873002/diff/60001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.cc:204: std::inserter(*first,
first->end()));
On 2016/12/12 10:09:21, vasilii wrote:
> std::back_inserter?

Done.

[vasilii, 2016-12-12 12:53:38]

lgtm

[vabr (Chromium), 2016-12-12 19:26:53]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 19:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 21:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 21:46:43]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-12-13 07:50:54]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-12-13 07:51:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 07:55:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481615454138550,
"parent_rev": "37d684a83f9906832bcaabdce04dd088b60d1804", "commit_rev":
"1e13870adad91631b87234bd30fab3a69f1c9e41"}

[commit-bot: I haz the power, 2016-12-13 07:55:39]

Description was changed from

==========
Remove ScopedVector from PasswordStoreMac

BUG=555132
==========

to

==========
Remove ScopedVector from PasswordStoreMac

BUG=555132

Review-Url: https://codereview.chromium.org/2566873002
==========

[commit-bot: I haz the power, 2016-12-13 07:55:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-13 07:57:19]

Description was changed from

==========
Remove ScopedVector from PasswordStoreMac

BUG=555132

Review-Url: https://codereview.chromium.org/2566873002
==========

to

==========
Remove ScopedVector from PasswordStoreMac

BUG=555132

Committed: https://crrev.com/3a570aa0a8002d34d7e9327ffcd802b1bb7e96ac
Cr-Commit-Position: refs/heads/master@{#438093}
==========

[commit-bot: I haz the power, 2016-12-13 07:57:20]

Patchset 5 (id:??) landed as
https://crrev.com/3a570aa0a8002d34d7e9327ffcd802b1bb7e96ac
Cr-Commit-Position: refs/heads/master@{#438093}