Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 2566873002: Remove ScopedVector from PasswordStoreMac (Closed)
Patch Set: back_inserter Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index ac3a74e73e141c6fa2a57e25bcf8e462a014397b..c811bb41de40710e4ef53827787da565a4fc2148 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -136,7 +136,7 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {
};
// Build the forms vector and add the forms to the store.
- ScopedVector<PasswordForm> all_forms;
+ std::vector<std::unique_ptr<PasswordForm>> all_forms;
for (size_t i = 0; i < arraysize(form_data); ++i) {
all_forms.push_back(CreatePasswordFormFromDataForTesting(form_data[i]));
store->AddLogin(*all_forms.back());
@@ -398,7 +398,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithoutAffiliations) {
MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
store->SetAffiliatedMatchHelper(base::WrapUnique(mock_helper));
- ScopedVector<PasswordForm> all_credentials;
+ std::vector<std::unique_ptr<PasswordForm>> all_credentials;
for (size_t i = 0; i < arraysize(kTestCredentials); ++i) {
all_credentials.push_back(
CreatePasswordFormFromDataForTesting(kTestCredentials[i]));
@@ -503,7 +503,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliations) {
MockAffiliatedMatchHelper* mock_helper = new MockAffiliatedMatchHelper;
store->SetAffiliatedMatchHelper(base::WrapUnique(mock_helper));
- ScopedVector<PasswordForm> all_credentials;
+ std::vector<std::unique_ptr<PasswordForm>> all_credentials;
for (size_t i = 0; i < arraysize(kTestCredentials); ++i) {
all_credentials.push_back(
CreatePasswordFormFromDataForTesting(kTestCredentials[i]));
@@ -687,7 +687,7 @@ TEST_F(PasswordStoreTest, MAYBE_UpdatePasswordsStoredForAffiliatedWebsites) {
base::Closure());
// Set up the initial test data set.
- ScopedVector<PasswordForm> all_credentials;
+ std::vector<std::unique_ptr<PasswordForm>> all_credentials;
for (size_t i = 0; i < arraysize(kTestCredentials); ++i) {
all_credentials.push_back(
CreatePasswordFormFromDataForTesting(kTestCredentials[i]));
@@ -795,7 +795,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliatedRealms) {
store->RemoveLoginsCreatedBetween(base::Time(), base::Time::Max(),
base::Closure());
- ScopedVector<PasswordForm> all_credentials;
+ std::vector<std::unique_ptr<PasswordForm>> all_credentials;
for (size_t i = 0; i < arraysize(kTestCredentials); ++i) {
all_credentials.push_back(
CreatePasswordFormFromDataForTesting(kTestCredentials[i]));

Powered by Google App Engine
This is Rietveld 408576698