Remove ScopedVector from PasswordStoreX

Remove ScopedVector from PasswordStoreX

BUG=555132
Committed: https://crrev.com/8a03095c9cc3ee8161084443acc6ea340c1b8490
Cr-Commit-Position: refs/heads/master@{#438087}

[vabr (Chromium), 2016-12-11 16:29:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 16:29:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 16:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 16:47:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-12-11 16:49:56]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-11 16:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 17:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-11 17:46:20]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-12-12 06:58:24]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-12-12 06:58:25]

Hi Vadym,

Please review.
Thanks!
Vaclav

[vabr (Chromium), 2016-12-12 11:19:27]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2016-12-12 11:19:27]

Hi Vasilii,

Vadym is likely not able to review this CL today. If you find time, please feel
free to review.

Thanks!
Vaclav

[vasilii, 2016-12-12 18:10:57]

lgtm

https://codereview.chromium.org/2565173002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_kwallet_x.cc (right):

https://codereview.chromium.org/2565173002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_kwallet_x.cc:669:
std::inserter(*forms, forms->end()));
back_inserter?

https://codereview.chromium.org/2565173002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_manager_util.cc (right):

https://codereview.chromium.org/2565173002/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_util.cc:57: *it =
nullptr;
not needed.

[vabr (Chromium), 2016-12-12 18:34:26]

Thank you, Vasilii!

Vaclav

https://codereview.chromium.org/2565173002/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/native_backend_kwallet_x.cc (right):

https://codereview.chromium.org/2565173002/diff/20001/chrome/browser/password...
chrome/browser/password_manager/native_backend_kwallet_x.cc:669:
std::inserter(*forms, forms->end()));
On 2016/12/12 18:10:57, vasilii wrote:
> back_inserter?

Done.

https://codereview.chromium.org/2565173002/diff/20001/components/password_man...
File components/password_manager/core/browser/password_manager_util.cc (right):

https://codereview.chromium.org/2565173002/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_util.cc:47: if
(autofill::ArePasswordFormUniqueKeyEqual(**it, *unique_forms.back())) {
Based on your explanation, I'm dropping the unnecessary autofill:: again.

https://codereview.chromium.org/2565173002/diff/20001/components/password_man...
components/password_manager/core/browser/password_manager_util.cc:57: *it =
nullptr;
On 2016/12/12 18:10:57, vasilii wrote:
> not needed.

Well spotted, thanks!

[vabr (Chromium), 2016-12-12 18:34:36]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-12-12 18:34:37]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2565173002/#ps40001
(title: "back_inserter, no =nullptr, drop autofill::")

[commit-bot: I haz the power, 2016-12-12 18:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:46:36]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-12-13 06:11:44]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-12-13 06:12:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:55:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481609504445870,
"parent_rev": "f041e19ccad037c4ee64fd036598f78a4c50687c", "commit_rev":
"cc7aa3ac9cfc7b4e8d2c6aef99fb8ce6a681a716"}

[commit-bot: I haz the power, 2016-12-13 06:55:50]

Description was changed from

==========
Remove ScopedVector from PasswordStoreX

BUG=555132
==========

to

==========
Remove ScopedVector from PasswordStoreX

BUG=555132

Review-Url: https://codereview.chromium.org/2565173002
==========

[commit-bot: I haz the power, 2016-12-13 06:55:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 06:58:58]

Description was changed from

==========
Remove ScopedVector from PasswordStoreX

BUG=555132

Review-Url: https://codereview.chromium.org/2565173002
==========

to

==========
Remove ScopedVector from PasswordStoreX

BUG=555132

Committed: https://crrev.com/8a03095c9cc3ee8161084443acc6ea340c1b8490
Cr-Commit-Position: refs/heads/master@{#438087}
==========

[commit-bot: I haz the power, 2016-12-13 06:58:59]

Patchset 3 (id:??) landed as
https://crrev.com/8a03095c9cc3ee8161084443acc6ea340c1b8490
Cr-Commit-Position: refs/heads/master@{#438087}