Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5987)

Unified Diff: chrome/browser/password_manager/password_store_mac.h

Issue 2566873002: Remove ScopedVector from PasswordStoreMac (Closed)
Patch Set: back_inserter Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac.h
diff --git a/chrome/browser/password_manager/password_store_mac.h b/chrome/browser/password_manager/password_store_mac.h
index b7a581502c5c2a7ab67f93c681df02bd65782c34..7389a3b830c257b2073a2fb634dbf90671f7b4af 100644
--- a/chrome/browser/password_manager/password_store_mac.h
+++ b/chrome/browser/password_manager/password_store_mac.h
@@ -11,7 +11,6 @@
#include "base/callback_forward.h"
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/threading/thread.h"
#include "components/password_manager/core/browser/login_database.h"
#include "components/password_manager/core/browser/password_store.h"
@@ -128,16 +127,18 @@ class PasswordStoreMac : public password_manager::PasswordStore {
// Removes the given forms from the database. After the call |forms| contains
// only those forms which were successfully removed.
- void RemoveDatabaseForms(ScopedVector<autofill::PasswordForm>* forms);
+ void RemoveDatabaseForms(
+ std::vector<std::unique_ptr<autofill::PasswordForm>>* forms);
// Removes the given forms from the Keychain.
void RemoveKeychainForms(
- const std::vector<autofill::PasswordForm*>& forms);
+ const std::vector<std::unique_ptr<autofill::PasswordForm>>& forms);
// Searches the database for forms without a corresponding entry in the
// keychain. Removes those forms from the database, and adds them to
// |orphaned_forms|.
- void CleanOrphanedForms(ScopedVector<autofill::PasswordForm>* orphaned_forms);
+ void CleanOrphanedForms(
+ std::vector<std::unique_ptr<autofill::PasswordForm>>* orphaned_forms);
std::unique_ptr<crypto::AppleKeychain> keychain_;

Powered by Google App Engine
This is Rietveld 408576698