components/password_manager/core/browser/login_database_ios_unittest.cc - Issue 2566873002: Remove ScopedVector from PasswordStoreMac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_ios_unittest.cc

Issue 2566873002: Remove ScopedVector from PasswordStoreMac (Closed)

Patch Set: back_inserter Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_ios_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_ios_unittest.cc b/components/password_manager/core/browser/login_database_ios_unittest.cc

index b604d673e0ef75e3e253af75f04bf4ea8a62349e..4ada9cfe88b7aa691e82b24bc21b1bd2ee6a7245 100644

--- a/components/password_manager/core/browser/login_database_ios_unittest.cc

+++ b/components/password_manager/core/browser/login_database_ios_unittest.cc

@@ -116,7 +116,7 @@ TEST_F(LoginDatabaseIOSTest, UpdateLogin) {

login_db_->UpdateLogin(form);

ASSERT_EQ(1u, changes.size());

- ScopedVector<PasswordForm> forms;

+ std::vector<std::unique_ptr<PasswordForm>> forms;

EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));

ASSERT_EQ(1U, forms.size());

@@ -135,7 +135,7 @@ TEST_F(LoginDatabaseIOSTest, RemoveLogin) {

ignore_result(login_db_->RemoveLogin(form));

- ScopedVector<PasswordForm> forms;

+ std::vector<std::unique_ptr<PasswordForm>> forms;

EXPECT_TRUE(login_db_->GetLogins(PasswordStore::FormDigest(form), &forms));

ASSERT_EQ(0U, forms.size());

@@ -171,7 +171,7 @@ TEST_F(LoginDatabaseIOSTest, RemoveLoginsCreatedBetween) {

PasswordStore::FormDigest form = {PasswordForm::SCHEME_HTML,

"http://www.example.com", GURL()};

- ScopedVector<PasswordForm> logins;

+ std::vector<std::unique_ptr<PasswordForm>> logins;

EXPECT_TRUE(login_db_->GetLogins(form, &logins));

ASSERT_EQ(2U, logins.size());