Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: components/password_manager/core/browser/password_manager_util.cc

Issue 2566873002: Remove ScopedVector from PasswordStoreMac (Closed)
Patch Set: back_inserter Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_util.cc
diff --git a/components/password_manager/core/browser/password_manager_util.cc b/components/password_manager/core/browser/password_manager_util.cc
index d2fa75e2ac603b280a3a8539cf9f4d76e658e2f9..3e7592a6e67d7d399736d865cf7efcd916a66419 100644
--- a/components/password_manager/core/browser/password_manager_util.cc
+++ b/components/password_manager/core/browser/password_manager_util.cc
@@ -81,17 +81,6 @@ void TrimUsernameOnlyCredentials(
});
}
-std::vector<std::unique_ptr<autofill::PasswordForm>> ConvertScopedVector(
- ScopedVector<autofill::PasswordForm> old_vector) {
- std::vector<std::unique_ptr<autofill::PasswordForm>> new_vector;
- new_vector.reserve(old_vector.size());
- for (auto* form : old_vector) {
- new_vector.push_back(base::WrapUnique(form));
- }
- old_vector.weak_clear(); // All owned by |new_vector| by now.
- return new_vector;
-}
-
bool IsLoggingActive(const password_manager::PasswordManagerClient* client) {
const password_manager::LogManager* log_manager = client->GetLogManager();
return log_manager && log_manager->IsLoggingActive();

Powered by Google App Engine
This is Rietveld 408576698